Skip to content

Remove diff expansion background colors

What does this MR do and why?

Removes differentiating background color from lines in a diff that have been expanded.

See discussion at #425590 (closed) for context.

References

Screenshots or screen recordings

Theme Before After
Light gdk.test_3000_flightjs_Flight_-_merge_requests_47_diffs.png gdk.test_3000_flightjs_Flight_-_merge_requests_47_diffs (18).png
Dark gdk.test_3000_flightjs_Flight_-_merge_requests_47_diffs (5).png gdk.test_3000_flightjs_Flight_-_merge_requests_47_diffs (3).png
Solarized light gdk.test_3000_flightjs_Flight_-_merge_requests_47_diffs (6).png gdk.test_3000_flightjs_Flight_-_merge_requests_47_diffs (8).png
Solarized dark gdk.test_3000_flightjs_Flight_-_merge_requests_47_diffs (10).png gdk.test_3000_flightjs_Flight_-_merge_requests_47_diffs (9).png
Monokai gdk.test_3000_flightjs_Flight_-_merge_requests_47_diffs (12).png gdk.test_3000_flightjs_Flight_-_merge_requests_47_diffs (14).png
None (no change) gdk.test_3000_flightjs_Flight_-_merge_requests_47_diffs (17).png gdk.test_3000_flightjs_Flight_-_merge_requests_47_diffs (15).png

How to set up and validate locally

  1. Check out this branch
  2. Visit or create an MR in the GDK where there are >20 lines before, after, or between changes in the diff (so that there will be collapsed sections)
  3. Expand a collapsed section in a diff
  4. The expanded lines will not have any differentiating background color, they will appear normal (i.e., they will look the same as unchanged lines that were not collapsed in the diff)

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Chad Lavimoniere

Merge request reports

Loading