Skip to content

Fix fetching of undismissed vulnerabilities

Avielle Wolfe requested to merge 36958-fix-undismissed into master

What does this MR do?

Because we match feedback to occurrences from different sources (including the database), full matching of a vulnerability occurrence with its feedback requires a comparison of the project_fingerprint, project, and category.

We were only checking the project_fingerprint, so we were reporting undismissed feedback as dismissed if there was another dismissal feedback that had the same project_fingerprint but was either for another project or in another report type.

Fixes #36958 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Avielle Wolfe

Merge request reports