Hide dismissed action in security dashboard is also hiding un-dismissed vulnerabilities

Summary

Non-dismissed vulnerabilities are being hidden when the hide dismissed vulnerabilities toggle is activated.

dismiss_bug

Steps to reproduce

⚠ Only reproducible on the project dashboard.

⚠ Saw this happen on the group dashboard only once and when that happened I saw the error: Error fetching results... so this could be due to a loading/fetching issue...

Example Project

https://gitlab.com/gitlab-org/gitlab/security/dashboard/?scope=all&days=90

What is the current bug behavior?

  • Some non-dismissed vulnerabilities are being hidden when the hide dismissed vulnerabilities toggle is activated.

What is the expected correct behavior?

  • Only dismissed vulnerabilities are hidden when the hide dismissed toggle is activated

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)

Output of checks

(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)

Results of GitLab environment info

Expand for output related to GitLab environment info 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:env:info)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production)

Results of GitLab application Check

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)


(we will only investigate if the tests are passing)

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Edited by Andy Volpe