Check Allow immediate deletion
admin setting in group/project listing pages
Depends on Add the allow_immediate_namespaces_deletion app... (!205554 - merged). Related to #456679 (closed)
What does this MR do and why?
In !205556 (merged) we are adding a Allow immediate deletion
admin setting. When this setting is false
regular users cannot immediately delete groups or projects. This MR also changes the delete label in the Inactive
tab to Delete immediately
on project lists. This was already done on group lists.
For some history, we were originally going to do this functionality with the disallow_immediate_deletion
feature flag but have pivoted to this admin setting. The admin setting defaults to true
and the disallow_immediate_deletion
feature flag is disabled so we can switch without issues.
The feature is behind by the allow_immediate_namespaces_deletion
feature flag. Documentation has been updated to explain the new setting, and tests have been added to verify the functionality works correctly.
References
- Implements to Support disabled action in group/project listin... (#570697 - closed)
- Part of Introduce a new "Allow immediate deletion" appl... (#569453)
Screenshots or screen recordings
How to set up and validate locally
allow_immediate_namespaces_deletion
FF disabled
With the - Go to
/dashboard/projects
and/or/dashboard/groups
- Mark a group or project for deletion
- Immediate deletion should be available in the
Inactive
tab
allow_immediate_namespaces_deletion
FF enabled
With the - Go to
/rails/features
and enableallow_immediate_namespaces_deletion
FF
allow_immediate_namespaces_deletion
setting enabled
With the - Go to
/dashboard/projects
and/or/dashboard/groups
- Mark a group or project for deletion
- Immediate deletion should be available in the
Inactive
tab
allow_immediate_namespaces_deletion
setting disabled
With the - Open the rails console with
bin/rails console
- Run
ApplicationSetting.first.update!(allow_immediate_namespaces_deletion: false)
- Go to
/dashboard/projects
and/or/dashboard/groups
- Mark a group or project for deletion
- Immediate deletion should not be available in the
Inactive
tab
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.