Upgrade rspec-rails to 4.0.0.beta3
What does this MR do?
https://github.com/rspec/rspec-rails/blob/master/Changelog.md
https://github.com/rspec/rspec-rails/compare/v3.8.0...v4.0.0.beta3
We need this because of a Rails 6 bug in https://github.com/rspec/rspec-rails/issues/2155 which caused controller specs to fail.
Also fixed view specs that now fail in Rails 6, extracted from: !19891 (diffs)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Rémy Coutable