Rollout UserWithId Per Environment Spec
What does this MR do?
Issue: #34363 (closed)
This MR does the following:
- Migrate existing feature flag scope data
The current target users feature (https://docs.gitlab.com/ee/user/project/operations/feature_flags.html#target-users-strategy) interprets a disabled scope in the database with a userWithId strategy as an enabled scope for Unleash clients. This was implemented here: !15500 (merged)
This makes this change permanently in the database, so that we aren't changing a user's effective feature flag settings.
-
Effectively reverts !15500 (merged).
-
Removes the feature flag on the frontend implementation of #34363 (closed), enabling the feature.
The data migration in this MR is expected to take a few seconds to run on gitlab.com. (!20325 (comment 250837047))
Screenshots
New target environments after this MR:
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team