Skip to content

Fix webauthn authentication in Firefox

Eduardo Sanz Garcíarequested to merge
eduardosanz/fix-webauthn-firefox into master

What does this MR do and why?

Fix webauthn authentication in Firefox

In Firefox, passing a reactive prop (Proxy) as publicKey in navigator.credentials.get causes an internal error: Promise rejection value is a non-unwrappable cross-compartment wrapper. The most probable reason for this is that convertGetParams returns some sophisticated data structures (ArrayBuffer and Uint8Array).

We fixed this by passing to publicKey a non-reactive prop in this way: publicKey: convertGetParams(this.webauthnParams).

Changelog: fixed

References

Related to Error with your device after log in (WebAuthn) (#560916 - closed)

Screenshots or screen recordings

No changes

How to set up and validate locally

In Firefox, try to authenticate using a WebAuthn device as a second factor.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Eduardo Sanz García

Merge request reports