Fix: Atom feed broken when supplying ref_type
What does this MR do and why?
Contributes to #562693 (closed)
Problem
The atom feed for commits fails to render entries when the ref_type
parameter is provided. This occurs because the qualified ref name has a
suffix .atom that is not removed.
Solution
Recalculate @fully_qualified_ref after .atom suffix was removed.
References
Commit feed broken in .atom format when passing... (#562693 - closed)
Screenshots or screen recordings
| Before | After |
|---|---|
![]() |
![]() |
How to set up and validate locally
- Visit http://gdk.test:3000/gitlab-org/gitlab-test/-/commits/master.atom
- You should see entries in the feed
- Visit http://gdk.test:3000/gitlab-org/gitlab-test/-/commits/master.atom?ref_type=heads
- You should still see entries in the feed
- Visit http://gdk.test:3000/gitlab-org/gitlab-test/-/commits/master.atom?ref_type=tags
- You should see 404 page
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #562693 (closed)

