Commit feed broken in .atom format when passing ref_type

While working on CommitList GraphQL query (#541920 - closed) I noticed that the atom feed for commits appears to be broken when supplying the ref_type.

No ref_type

When we omit the ref type we correctly get the list of entries for the branch or tag e.g.

for a branch

https://gitlab.com/gitlab-org/gitlab/-/commits/master.atom

image

for a tag

https://gitlab.com/gitlab-org/gitlab/-/commits/v18.3.0-ee.atom

image

ref_type=heads (branch)

When we supply ref_type=heads we return no entries e.g.

https://gitlab.com/gitlab-org/gitlab/-/commits/master.atom?ref_type=heads

image

ref_type=tags

When we supply ref_type=tags we return no entries e.g.

https://gitlab.com/gitlab-org/gitlab/-/commits/master.atom?ref_type=tags

image

What should happen

Supplying the correct ref_type should still render the entries. If the ref_type and ref name results in no match then an empty feed would be correct.

Edited by Joe Woodward