Handle MR pipelines against source branch in protected pipelines

Jayakrishnan Mallisseryrequested to merge
protected-merge-request-pipelines-fixes into master

Why this MR ?

  • To resolve this issue

  • In this Epic we implemented a feature enhancement wherein we let MR pipelines between protected branches can access protected variables.

  • This comment - !196304 (comment 2611964312) raised some pending tasks that needs to be completed to make the feature more well rounded. This MR implements these tasks

What does this MR do ?

  • In Ci::Pipeline#protected_for_merge_request?, handle the scenario for protected MR pipelines that run against source branch and NOT merge request ref.

  • Currently, we DO NOT have any bug as this scenario is already handled in the validation phase when a pipeline is created but handling this scenario in Ci::Pipeline#protected_for_merge_request? is important because relying on existing check seems a bit brittle

  • Update 2 documentation texts that needs changes as a result of delivery of the original feature epic

References

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jayakrishnan Mallissery

Merge request reports