Skip to content

Follow up tasks for Protected Merge Request Pipelines Feature

  • In this Epic we implemented a feature enhancement wherein we let MR pipelines between protected branches can access protected variables.

  • In this comment - !196304 (comment 2611964312) @allison.browne raised some pending tasks that needs to be completed to make the feature more well rounded. This issue is to tackle these follow up tasks

  • Apart from 2 doc changes, the main task is to handle the scenario for protected MR pipelines that run against source branch and NOT merge request ref in Ci::Pipeline#protected_for_merge_request?

  • Currently, we DO NOT have any bug as this scenario is already handled in the validation phase when a pipeline is created but handling this scenario in Ci::Pipeline#protected_for_merge_request? is important because relying on existing check seems a bit brittle

Things to do

Edited by Jayakrishnan Mallissery