Delete the search_refactor_membership_filter feature flag

This feature flag was introduced in 18.2 and has been marked as ready for removal with the ~"feature flag::ready for removal" label, bypassing the standard milestone cutoff requirements.

As part of our process we want to ensure feature flags don't stay too long in the codebase.

Rollout issue: #549851 (closed)

Remaining mentions of the feature flag (click to expand)

ee/spec/lib/search/elastic/filters_spec.rb
3570:            stub_feature_flags(search_refactor_membership_filter: false)
3593:                stub_feature_flags(search_refactor_membership_filter: false)
3614:                stub_feature_flags(search_refactor_membership_filter: false)
3637:                stub_feature_flags(search_refactor_membership_filter: false)
3658:                stub_feature_flags(search_refactor_membership_filter: false)
3683:              stub_feature_flags(search_refactor_membership_filter: false)
3706:              stub_feature_flags(search_refactor_membership_filter: false)
3724:            stub_feature_flags(search_refactor_membership_filter: false)
3741:            stub_feature_flags(search_refactor_membership_filter: false)
3773:            stub_feature_flags(search_refactor_membership_filter: false)
3796:                stub_feature_flags(search_refactor_membership_filter: false)
3817:                stub_feature_flags(search_refactor_membership_filter: false)
3840:                stub_feature_flags(search_refactor_membership_filter: false)
3866:                  stub_feature_flags(search_refactor_membership_filter: false)
3888:                stub_feature_flags(search_refactor_membership_filter: false)
3913:              stub_feature_flags(search_refactor_membership_filter: false)
3935:              stub_feature_flags(search_refactor_membership_filter: false)
3953:            stub_feature_flags(search_refactor_membership_filter: false)
3970:            stub_feature_flags(search_refactor_membership_filter: false)
4002:            stub_feature_flags(search_refactor_membership_filter: false)
4025:                stub_feature_flags(search_refactor_membership_filter: false)
4046:                stub_feature_flags(search_refactor_membership_filter: false)
4069:                stub_feature_flags(search_refactor_membership_filter: false)
4090:                stub_feature_flags(search_refactor_membership_filter: false)
4115:              stub_feature_flags(search_refactor_membership_filter: false)
4138:              stub_feature_flags(search_refactor_membership_filter: false)
4156:            stub_feature_flags(search_refactor_membership_filter: false)
4173:            stub_feature_flags(search_refactor_membership_filter: false)
4201:          stub_feature_flags(search_refactor_membership_filter: false)
4227:          stub_feature_flags(search_refactor_membership_filter: false)

ee/config/feature_flags/gitlab_com_derisk/search_refactor_membership_filter.yml
2:name: search_refactor_membership_filter

ee/lib/search/elastic/filters.rb
26:          if Feature.enabled?(:search_refactor_membership_filter, options[:current_user])
1315:        # @deprecated - will be removed with search_refactor_membership_filter feature flag
1427:        # @deprecated - will be removed with search_refactor_membership_filter flag
1665:        # @deprecated - will be removed with search_refactor_membership_filter feature flag
1846:        # @deprecated - will be removed with search_refactor_membership_filter feature flag
1866:        # @deprecated - will be removed with search_refactor_membership_filter feature flag

ee/spec/lib/search/elastic/filters_spec.rb
3566:        context 'when search_refactor_membership_filter feature flag is false' do
3570:            stub_feature_flags(search_refactor_membership_filter: false)
3589:            context 'when search_refactor_membership_filter feature flag is false' do
3593:                stub_feature_flags(search_refactor_membership_filter: false)
3610:            context 'when search_refactor_membership_filter feature flag is false' do
3614:                stub_feature_flags(search_refactor_membership_filter: false)
3633:            context 'when search_refactor_membership_filter feature flag is false' do
3637:                stub_feature_flags(search_refactor_membership_filter: false)
3654:            context 'when search_refactor_membership_filter feature flag is false' do
3658:                stub_feature_flags(search_refactor_membership_filter: false)
3679:          context 'when search_refactor_membership_filter feature flag is false' do
3683:              stub_feature_flags(search_refactor_membership_filter: false)
3702:          context 'when search_refactor_membership_filter feature flag is false' do
3706:              stub_feature_flags(search_refactor_membership_filter: false)
3720:        context 'when search_refactor_membership_filter feature flag is false' do
3724:            stub_feature_flags(search_refactor_membership_filter: false)
3737:        context 'when search_refactor_membership_filter feature flag is false' do
3741:            stub_feature_flags(search_refactor_membership_filter: false)
3769:        context 'when search_refactor_membership_filter feature flag is false' do
3773:            stub_feature_flags(search_refactor_membership_filter: false)
3792:            context 'when search_refactor_membership_filter feature flag is false' do
3796:                stub_feature_flags(search_refactor_membership_filter: false)
3813:            context 'when search_refactor_membership_filter feature flag is false' do
3817:                stub_feature_flags(search_refactor_membership_filter: false)
3836:            context 'when search_refactor_membership_filter feature flag is false' do
3840:                stub_feature_flags(search_refactor_membership_filter: false)
3862:              context 'when search_refactor_membership_filter feature flag is false' do
3866:                  stub_feature_flags(search_refactor_membership_filter: false)
3884:            context 'when search_refactor_membership_filter feature flag is false' do
3888:                stub_feature_flags(search_refactor_membership_filter: false)
3909:          context 'when search_refactor_membership_filter feature flag is false' do
3913:              stub_feature_flags(search_refactor_membership_filter: false)
3931:          context 'when search_refactor_membership_filter feature flag is false' do
3935:              stub_feature_flags(search_refactor_membership_filter: false)
3949:        context 'when search_refactor_membership_filter feature flag is false' do
3953:            stub_feature_flags(search_refactor_membership_filter: false)
3966:        context 'when search_refactor_membership_filter feature flag is false' do
3970:            stub_feature_flags(search_refactor_membership_filter: false)
3998:        context 'when search_refactor_membership_filter feature flag is false' do
4002:            stub_feature_flags(search_refactor_membership_filter: false)
4021:            context 'when search_refactor_membership_filter feature flag is false' do
4025:                stub_feature_flags(search_refactor_membership_filter: false)
4042:            context 'when search_refactor_membership_filter feature flag is false' do
4046:                stub_feature_flags(search_refactor_membership_filter: false)
4065:            context 'when search_refactor_membership_filter feature flag is false' do
4069:                stub_feature_flags(search_refactor_membership_filter: false)
4086:            context 'when search_refactor_membership_filter feature flag is false' do
4090:                stub_feature_flags(search_refactor_membership_filter: false)
4111:          context 'when search_refactor_membership_filter feature flag is false' do
4115:              stub_feature_flags(search_refactor_membership_filter: false)
4134:          context 'when search_refactor_membership_filter feature flag is false' do
4138:              stub_feature_flags(search_refactor_membership_filter: false)
4152:        context 'when search_refactor_membership_filter feature flag is false' do
4156:            stub_feature_flags(search_refactor_membership_filter: false)
4169:        context 'when search_refactor_membership_filter feature flag is false' do
4173:            stub_feature_flags(search_refactor_membership_filter: false)
4197:      context 'when search_refactor_membership_filter feature flag is false' do
4201:          stub_feature_flags(search_refactor_membership_filter: false)
4223:      context 'when search_refactor_membership_filter feature flag is false' do
4227:          stub_feature_flags(search_refactor_membership_filter: false)

Currently the feature flag is enabled on production

It is possible that this MR will still need some changes to remove references to the feature flag in the code. At the moment the gitlab-housekeeper is not always capable of removing all references so you must check the diff and pipeline failures to confirm if there are any issues. It is the responsibility of groupglobal search to push those changes to this branch.

Note: If you do not want to remove this feature flag at this time, you can add an intended_to_rollout_by_date attribute in the feature flag YAML file to prevent automated removal.

TODO for the reviewers before merging this MR

• See the status of the rollout by checking #549851 (closed), https://gitlab.com/gitlab-com/gl-infra/feature-flag-log/-/issues/?search=search_refactor_membership_filter&sort=created_date&state=all&label_name%5B%5D=host%3A%3Agitlab.com
• Verify the feature flag status via chatops by running /chatops run feature get search_refactor_membership_filter.
• Search for references to SearchRefactorMembershipFilter in frontend part of code
• Search for references to search_refactor_membership_filter in code
• Check if we need to remove any Gem or other related code by looking at the changes in !195170 (merged)

This change was generated by gitlab-housekeeper locally using the Keeps::DeleteOldFeatureFlags keep.

To provide feedback on your experience with gitlab-housekeeper please create an issue with the label GitLab Housekeeper and consider pinging the author of this keep.