Introduced new FF for group_saml

Smriti Gargrequested to merge
smriti-554668/followup_session_timeout_attribute into master

What does this MR do and why?

#554668 (closed)

For the follow up comments on !194914 (merged)

I introduced another Feature flag to control the check for session_not_on_or_after attribute for group_saml since there were a few limitations : -

  1. We cannot limit the scope of a Feature flag in class ee/app/controllers/ee/omniauth_callbacks_controller.rb by group
  2. We cannot scope a feature flag by user in class ee/lib/gitlab/auth/group_saml/sso_enforcer.rb since we do not have user reference in class method - sessions_time_remaining_for_expiry

We cannot have one FF scoped by user in one scenario and scoped by group in another. Hence best case was to have two FFs to control enablement of this feature for self-managed v/s group-saml scenario

Merge request reports