Merge '535187-fix-console-errors' into '17-11-stable-ee'
What does this MR do and why?
This MR backports !188652 (merged) into the 17.11 stable branch. Pre this fix we were seeing ~1.5 million log errors within 24 hours, post this fix we see 200 errors within 5 days (edge cases). This bug is directly impacting GitLab Dedicated tenants' availability SLAs.
The bug is an issue with upstream package code where the skip
function is not working when using the subscribeToMore
hook with vue-apollo
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch. -
The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes). -
This MR has a severity label assigned (if applicable). -
Set the milestone of the merge request to match the target backport branch version. -
This MR has been approved by a maintainer (only one approval is required). -
Ensure the e2e:test-on-omnibus-ee
job has either succeeded or been approved by a Software Engineer in Test.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releases
Slack channel (internal only).
Edited by Jose Ivan Vargas