Refactor subscribeToMore to be manual vs hook
What does this MR do and why?
Attempts to solve the issue of the thrown error: Variable $pipelineId of type CiPipelineID! was provided invalid value
For some reason the skip
function isn't behaving like we want it to, so it was recommend to move the subscribeToMore
to the result
hook and avoid skip
and do a hard if
check for the flag.
I'm unable to re-produce the errors locally but they show up in these logs and Sentry.
More context in this thread #535187 (comment 2454481066)
References
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
- Ensure real-time still works as expected for a pipeline detail pages overall status and the last commit section for a repository.
- Ensure with feature flag
ci_pipeline_status_realtime
off the websocket subscription is not initaited. - Ensure with feature flag
ci_pipeline_status_realtime
on the websocket subscription is initaited. - Ensure the refactor the a manual
subscribeToMore
was done correctly
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #535187 (closed)
Edited by Payton Burdette