Fix errors in GraphQL Todos API due to missing TargetTypeEnum values

What does this MR do?

Fixes missing target types in TargetTypeEnum and separates the EE-specific types.

Adds calls_gitaly for the TodoType#body field, as an error is raised when requesting the todo.body field for a Commit Todo:

RuntimeError (Gitaly is called for field 'body' on Types::TodoType
- please either specify a constant complexity or add
`calls_gitaly: true` to the field declaration)

When the Todo (a polymorphic model) has a target_type of Commit, requesting the body field calls Gitaly (Todo#body calls Todo#target which fetches the Commit from Gitaly) and we get the above error.

I've set calls_gitaly: true for the TodoType#body field (affecting all Todos, regardless of the target_type) in order to avoid the error, while we work out a better solution.

• #34757 (comment 234752665)
• #34757 (closed)
• #34948

Does this MR meet the acceptance criteria?

Conformity

• [-] Changelog entry
• [-] Documentation created/updated or follow-up review issue created
• Code review guidelines
• Merge request performance guidelines
• Style guides
• [-] Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• [-] Tested in all supported browsers

changed milestone to %12.5

added Category:Design Management GraphQL api devopsplan priority2 reproduced on GitLab.com severity2 todos typebug + 1 deleted label

mentioned in issue #34757 (closed)

added backstage [DEPRECATED] label

cc @smcgivern @pderichs

removed backstage [DEPRECATED] label

changed title from Fix errors in GraphQL TodosQuery to Fix errors in GraphQL Todos API due to missing TargetTypeEnum values

added 1 commit

• 06ff4f6d - Add changelog entry

Compare with previous version

changed the description

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
backend	Doug Stull (@dstull)	Nick Thomas (@nick.thomas)

Generated by 🚫 Danger

added 1 commit

• 6a53268b - Fix errors in GraphQL TodosQuery

Compare with previous version

mentioned in merge request !19068 (merged)

mentioned in merge request !18998 (closed)

mentioned in issue #34948

changed the description

resolved all threads

added 103 commits

• 6a53268b...b4bbc899 - 102 commits from branch master
• 80c56a66 - Fix errors in GraphQL TodosQuery

Compare with previous version

mentioned in issue #34951 (closed)

mentioned in issue #34972 (closed)

added 103 commits

• 80c56a66...e8928d60 - 102 commits from branch master
• 3ac0239a - Fix errors in GraphQL TodosQuery

Compare with previous version

added 102 commits

• 3ac0239a...3de90595 - 101 commits from branch master
• 9e7972f3 - Fix errors in GraphQL TodosQuery

Compare with previous version

resolved all threads

assigned to @digitalmoksha

added 1 commit

• 36c5f949 - Fix errors in GraphQL TodosQuery

Compare with previous version

Hi @digitalmoksha 👋 Could you please give this MR its first review? Thank you!

@.luke LGTM! 🚀 Nice job on splitting out the EE portion

unassigned @digitalmoksha

mentioned in merge request !19257 (merged)

added 167 commits

• 36c5f949...2d0fe31d - 166 commits from branch master
• a51ed1c4 - Fix errors in GraphQL TodosQuery

Compare with previous version

assigned to @jprovaznik

@jprovaznik Could you please give this MR a maintainer review? Thank you!

approved this merge request

Thanks @.luke, LGTM 👍

merged

mentioned in commit 01fd6f35

This merge request has been deployed to the GitLab.com environment gstg in GitLab auto-deploy version 12.5.201910311210-d5886f651a4.3ea7cde5d39.

A list of all the deployed commits can be found here.

---

🤖 If this message is incorrect, please create an issue in the Release Tools project.

added workflowstaging label

This merge request has been deployed to the GitLab.com environment gprd-cny in GitLab auto-deploy version 12.5.201910312010-60c5d4225eb.efb9aedada9.

A list of all the deployed commits can be found here.

---

🤖 If this message is incorrect, please create an issue in the Release Tools project.

added workflowcanary label and removed workflowstaging label

This merge request has been deployed to the GitLab.com environment gprd in GitLab auto-deploy version 12.5.201911051208-6ed176c0af2.b8eace52b50.

A list of all the deployed commits can be found here.

---

🤖 If this message is incorrect, please create an issue in the Release Tools project.

added workflowproduction label and removed workflowcanary label

changed the description

added groupproduct planning label and removed 1 deleted label