Fix UpdateTableSizes keep
What does this MR do and why?
This MR fixes a bug where UpdateTableSizes
keep was using the wrong database connection.
See this example MR where the table size classification is wrong.
Merge request reports
Activity
changed milestone to %17.10
assigned to @morefice
removed automation:bot-authored label
removed automation:gitlab-housekeeper-authored label
added pipelinetier-1 label
1 Warning 45f8975c: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
If you no longer require a database review, you can remove this suggestion by removing the database label and re-running the
danger-review
job.Reviewer roulette
Category Reviewer Maintainer backend @mbenayoun
(UTC+2, 1 hour ahead of author)
@grzesiek
(UTC+1, same timezone as author)
database @alexpooley
(UTC+8, 7 hours ahead of author)
@fcatteau
(UTC+1, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by ****requested review from @ahegyi
- Resolved by Omar Qunsul
- Resolved by Omar Qunsul
@ahegyi can you review this MR please?
added databasereviewed label and removed databasereview pending label
requested review from @OmarQunsulGitlab
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 45f8975cexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 31 | 0 | 10 | 0 | 41 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Create | 138 | 0 | 22 | 3 | 160 | ✅ | | Plan | 82 | 0 | 8 | 2 | 90 | ✅ | | Verify | 48 | 0 | 24 | 1 | 72 | ✅ | | Package | 24 | 0 | 14 | 1 | 38 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Govern | 79 | 0 | 13 | 1 | 92 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Secure | 5 | 0 | 3 | 1 | 8 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 425 | 0 | 131 | 9 | 556 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 45f8975cexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 82 | 0 | 12 | 0 | 94 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Create | 142 | 0 | 22 | 0 | 164 | ✅ | | Data Stores | 31 | 0 | 10 | 0 | 41 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Package | 29 | 0 | 15 | 0 | 44 | ✅ | | Verify | 49 | 0 | 23 | 0 | 72 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Secure | 5 | 0 | 3 | 0 | 8 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 442 | 0 | 130 | 0 | 572 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by ****- Resolved by Omar Qunsul