Skip to content
Snippets Groups Projects

Prevent CiIcon text color from being overridden

Merged Chad Lavimoniere requested to merge 20250226-clavimoniere-ci-icon-color-fix into master

What does this MR do and why?

Some rules affecting a elements can incorrectly override the text color of the CiIcon component. This MR adds the important decorator to the text color for CI icon so that it does not get overridden.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image
image image

How to set up and validate locally

  1. Start the GitLab development server locally
  2. Visit a job page (e.g., /flightjs/Flight/-/jobs/2523)
  3. Look at the Pipeline information in the right sidebar
  4. Verify that the CI icon text colors remain consistent and are not overridden by other styles
  5. Test different states:
    • Success (green)
    • Failed (red)
    • Running (blue)
    • Pending (gray)
  6. Check both light and dark themes
Edited by Chad Lavimoniere

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading