Skip to content
Snippets Groups Projects

Enable virtual_registry_maven_cleanup_new_worker_class by default

Merged David Fernandez requested to merge 515213-enable-by-default into master

:monkey: Context

In !177996 (merged), we finalized a pretty deep refactoring for Maven virtual registries. We introduced a new (partitioned) table for the caching aspect and in that MR, we updated all models to reference the new table.

Among the code changes, there was this worker that needed to be renamed. Worker class renames should follow https://docs.gitlab.com/ee/development/sidekiq/compatibility_across_updates.html#renaming-worker-classes.

This MR is step two of that process: enable the feature flag by default. So the overall progress on that process in #515213 (closed).

Note that the maven virtual registry is gated behind a wip feature flag. Thus, the feature flag changed here (the one for the worker class rename) is a feature flag within a feature flag.

:thinking: What does this MR do and why?

  • Enable virtual_registry_maven_cleanup_new_worker_class by default

:books: References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

:race_car: MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

:white_check_mark:

:desktop: Screenshots or screen recordings

None

:gear: How to set up and validate locally

Follow !165195 (merged).

Edited by David Fernandez

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading