Fixes the notebook/cells/markdown_spec Vue 3 failing spec
What does this MR do and why?
Fixes failing spec/frontend/notebook/cells/markdown_spec.js
Vue 3 specs
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
changed milestone to %17.10
added devopscreate frontend groupcode review typemaintenance vue3-migration labels
assigned to @iamphill
added pipelinetier-1 label
added sectiondev label
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @rhardarson
(UTC+1, 1 hour ahead of author)
@anna_vovchenko
(UTC+2, 2 hours ahead of author)
~"Tooling" Reviewer review is optional for ~"Tooling" @aturinske
(UTC-7, 7 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by ****added 1 commit
- 130c9d0e - Fixes the notebook/cells/markdown_spec Vue 3 failing spec
added 1 commit
- a63bc2cf - Fixes the notebook/cells/markdown_spec Vue 3 failing spec
added 934 commits
-
a63bc2cf...409482ad - 933 commits from branch
master
- 9777bd6d - Fixes the notebook/cells/markdown_spec Vue 3 failing spec
-
a63bc2cf...409482ad - 933 commits from branch
requested review from @jivanvl
added pipeline:mr-approved label
mentioned in issue jivanvl/manager-of-one#29
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 9777bd6dexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 82 | 0 | 8 | 2 | 90 | ✅ | | Govern | 79 | 0 | 13 | 1 | 92 | ✅ | | Verify | 48 | 0 | 24 | 1 | 72 | ✅ | | Data Stores | 31 | 0 | 10 | 0 | 41 | ✅ | | Package | 24 | 0 | 14 | 2 | 38 | ✅ | | Create | 138 | 0 | 22 | 3 | 160 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 4 | 0 | 4 | 1 | 8 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 424 | 0 | 132 | 10 | 556 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 9777bd6dexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 142 | 0 | 22 | 0 | 164 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Data Stores | 31 | 0 | 10 | 0 | 41 | ✅ | | Govern | 82 | 0 | 12 | 0 | 94 | ✅ | | Package | 29 | 0 | 15 | 0 | 44 | ✅ | | Verify | 49 | 0 | 23 | 0 | 72 | ✅ | | Secure | 4 | 0 | 4 | 0 | 8 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 441 | 0 | 131 | 0 | 572 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by ****mentioned in incident gitlab-org/quality/engineering-productivity/approved-mr-pipeline-incidents#1921
started a merge train