Fix housekeeper not requiring filter_identifiers
What does this MR do and why?
In !181094 (merged) we improved the filtering capabilities in Housekeeper and added a new class FilterIdentifiers. But unfortunately we did not require the class before using it and now it's breaking Housekeeper in CI (see https://ops.gitlab.net/gitlab-com/database-team/gitlab-com-database-testing/-/jobs/17251336 for an example).
You can also easily test this yourself by running any keep. I've tested locally with the example in the README.md and this fixes the problem.
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
changed milestone to %17.10
added groupglobal search maintenanceworkflow labels
requested review from @tigerwnz
assigned to @DylanGriffith
added typemaintenance label
added pipelinetier-1 label
added devopsfoundations sectioncore platform labels
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
added backend label
Reviewer roulette
Category Reviewer Maintainer backend @jfypk
(UTC+0, 11 hours behind author)
@kassio
(UTC+1, 10 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by ****cc @sdungarwal
FYI @splattael you may have noticed that your Housekeeper pipelines are all broken now. This MR should fix it.
mentioned in commit 4fb282fd
mentioned in merge request !181614 (merged)
mentioned in commit f6c55646
mentioned in commit 09ed6850