Skip to content
Snippets Groups Projects

Add controllers and frontend for DPoP

Merged Ameya Darshan requested to merge ameya-dpop-ui into master

What does this MR do and why?

This MR adds the controller and frontend code for Add DPoP checks in GraphQL and API requests (!169013 - merged).

Related to Sender constraining personal access tokens (#425130).

References

See the epic (Allow users to require demonstrated proof of po... (&14383)) for context, pre-work, and other related issues.

Screenshots or screen recordings

When dpop_authentication FF is disabled:

Screenshot_2025-02-11_at_11.18.57

When :dpop_authentication FF is enabled:

Screenshot_2025-02-11_at_11.20.03

How to set up and validate locally

  1. Checkout this branch locally.
  2. Run bin/rails db:migrate
  3. In rails console, enable the feature flag: Feature.enable(:dpop_authentication, User.first)
  4. Login as root.
  5. Go to Settings > Access tokens > Toggle the DPoP option.
  6. Confirm it persists in the database User.first.dpop_enabled and also on the frontend after refreshing the page.
Edited by Ameya Darshan

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Amy Qualls
  • Amy Qualls
  • Amy Qualls
  • Amy Qualls
  • Amy Qualls
  • @ameyadarshan I've got some string changes for you, but I'd also like to add some more info to the proposed docs.

  • Amy Qualls requested changes

    requested changes

  • mentioned in issue #461472 (closed)

  • Cindy Halim approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Cindy Halim requested review from @dpisek

    requested review from @dpisek

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 5ce85777

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Govern      | 79     | 0      | 13      | 0     | 92    | ✅     |
    | Plan        | 82     | 0      | 8       | 0     | 90    | ✅     |
    | Create      | 135    | 0      | 23      | 0     | 158   | ✅     |
    | Verify      | 51     | 0      | 21      | 0     | 72    | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Secure      | 5      | 0      | 3       | 0     | 8     | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 427    | 0      | 129     | 0     | 556   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for 5ce85777

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Create      | 140    | 0      | 22      | 0     | 162   | ✅     |
    | Govern      | 84     | 0      | 10      | 0     | 94    | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Verify      | 52     | 0      | 20      | 0     | 72    | ✅     |
    | Package     | 29     | 0      | 15      | 0     | 44    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Secure      | 3      | 0      | 5       | 0     | 8     | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 445    | 0      | 127     | 0     | 572   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    Edited by ****
  • Safwan Ahmed approved this merge request

    approved this merge request

  • Ameya Darshan added 1 commit

    added 1 commit

    • 03c4b20f - Apply 4 suggestion(s) to 2 file(s)

    Compare with previous version

  • Ameya Darshan added 1 commit

    added 1 commit

    • 633d2117 - Edit personal_access_tokens.md

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading