Skip to content
Snippets Groups Projects

Do not try to change exit codes if no access tokens is present

Merged David Dieulivol requested to merge ddieulivol-check_for_token_before_calling_api into master
All threads resolved!

Context

https://gitlab.com/gitlab-org/gitlab/-/issues/517124

What does this MR do and why?

Don't try to change the CI exit code if the TEST_FAILURES_PROJECT_TOKEN ENV variable isn't present, as we rely on it to fetch information from the GitLab API.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kev Kloss approved this merge request

    approved this merge request

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Kev Kloss enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Kev Kloss resolved all threads

    resolved all threads

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-cng: :white_check_mark: test report for 5416e547

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 52     | 0      | 20      | 0     | 72    | ✅     |
    | Create      | 140    | 0      | 22      | 0     | 162   | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Govern      | 83     | 0      | 11      | 0     | 94    | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Package     | 29     | 0      | 15      | 0     | 44    | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 443    | 0      | 128     | 0     | 571   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-gdk: :white_check_mark: test report for 5416e547

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Create      | 135    | 0      | 23      | 0     | 158   | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Plan        | 82     | 0      | 8       | 0     | 90    | ✅     |
    | Govern      | 78     | 0      | 14      | 0     | 92    | ✅     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Verify      | 51     | 0      | 21      | 0     | 72    | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Secure      | 4      | 0      | 3       | 0     | 7     | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 425    | 0      | 130     | 0     | 555   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    Edited by ****
  • merged

  • Kev Kloss mentioned in commit 2bf17cfd

    mentioned in commit 2bf17cfd

  • David Dieulivol mentioned in merge request !180402 (merged)

    mentioned in merge request !180402 (merged)

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading