Fix styles on error page when Vite is disabled
What does this MR do and why?
Fix styles on error page when Vite is disabled.
This is a follow up from Load app styles on error pages (!177825 - merged), which fixed styles when Vite is enabled, which is currently not the case in production.
It turns out the Vite check is unnecessary.
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
1.Disabled Vite on you local environment but running the following set of commands from your terminal:
gdk stop vite rails-web
gdk config set vite.enabled false
gdk config set webpack.enabled true
gdk reconfigure
gdk restart webpack rails-webLink to docs: https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/configuration.md#vite-settings 2. Visit a page that doesn't exist, such as http://127.0.0.1:3000/notapage
Related to #509301 (closed)
Merge request reports
Activity
changed milestone to %17.9
assigned to @fguibert
added pipelinetier-1 label
1 Warning 
You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.1 Message 
CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelogtrailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @micthomas
(UTC-5, 15 hours behind author)@atevans (UTC-8, 18 hours behind author)frontend @a_akgun (UTC+3, 7 hours behind author)@markrian (UTC+0, 10 hours behind author)Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by ****added 304 commits
-
5165c44a...604ea2e2 - 303 commits from branch
master - 0c54f5b5 - Fix styles on error page when Vite is disabled
-
5165c44a...604ea2e2 - 303 commits from branch
added workflowin review label and removed workflowin dev label
requested review from @patrickbajao and @ohoral
- Resolved by Olena Horal-Koretska
@patrickbajao Could you please review backend?
- Last reply by Olena Horal-Koretska
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publishergenerated test report!e2e-test-on-cng:
expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Govern | 84 | 0 | 10 | 0 | 94 | ✅ | | Create | 140 | 0 | 22 | 0 | 162 | ✅ | | Verify | 53 | 0 | 19 | 0 | 72 | ✅ | | Package | 29 | 0 | 15 | 0 | 44 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 445 | 0 | 126 | 0 | 571 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+e2e-test-on-gdk:
expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Create | 135 | 0 | 23 | 0 | 158 | ✅ | | Verify | 52 | 0 | 20 | 1 | 72 | ✅ | | Govern | 79 | 0 | 13 | 0 | 92 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Plan | 82 | 0 | 8 | 0 | 90 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Secure | 4 | 0 | 3 | 0 | 7 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 427 | 0 | 128 | 1 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+Edited by ****started a merge train
