feat: Work Items list view - show discussion count in FE
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you receive complimentary access to GitLab Duo.
Description
This MR adds capability to show the discussion count in FE.
The BE MR can be tracked on !179164 (merged)
Relates to #478633
Screenshot
Merge request reports
Activity
mentioned in merge request !179164 (merged)
added devopsplan groupproject management sectiondev typefeature labels
added Community contribution label
added pipelinetier-1 label
Thanks for your contribution to GitLab @vedant-jain03!
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
- If you need help, page a coach by clicking here or come say hi on Discord.
- When you're ready, request a review by clicking here.
- We welcome AI-generated contributions and offer complimentary access to GitLab Duo!
- To add labels to your merge request, comment
@gitlab-bot label ~"label1" ~"label2"
.
This message was generated automatically. Improve it or delete it.
added workflowin dev label
assigned to @vedant-jain03
added linked-issue label
@fernanda.toledo Do you mind taking the initial FE review of this please? This MR is dependent on the backend changes, which is handled in !179164 (merged), so when that is merged and this is rebased the changes will be just to the frontend
.graphql
files.requested review from @fernanda.toledo
added frontend label
- Resolved by Deepika Guliani
@vedant-jain03 FE changes look good, I can see the discussions icon and count in the group
/work_items
list page. We already have a test for theuserDiscussionsCount
field in theissuable_item_spec
file, so I don't think we need a new one for this change.Thank you for addressing this!
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
added pipelinetier-1 workflowin review labels and removed pipelinetier-2 workflowin dev labels
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
added work items label
- Resolved by Deepika Guliani
@deepika.guliani can you frontend maintainer review, please? FYI we need the BE MR to be merged first.
requested review from @deepika.guliani
added UX label
Thanks for helping us improve the UX of GitLab. Your contribution is appreciated! We have pinged our UX team, so stay tuned for their feedback.
This message was generated automatically. Improve it or delete it.
requested review from @nickbrandt
@vedant-jain03 this looks good from UX standpoint. Thanks for the addition!
added pipelinetier-2 label and removed pipelinetier-1 label
removed review request for @deepika.guliani
added 4703 commits
-
2261f129...c8944f01 - 4702 commits from branch
gitlab-org:master
- 590f588b - feat: Work Items list view - show discussion count in FE
-
2261f129...c8944f01 - 4702 commits from branch
Thank you for working on this @vedant-jain03
This looks great Let's get this mergedadded pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
requested review from @deepika.guliani
1 Warning This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @snachnolkar
(UTC+5.5)
@mgandres
(UTC+8)
UX @nickleonard
(UTC-6)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 9d994219 and 590f588b
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.88 MB 4.88 MB - 0.0 % mainChunk 3.78 MB 3.78 MB - 0.0 %
Note: We do not have exact data for 9d994219. So we have used data from: f05d8220.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 590f588bexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 82 | 0 | 8 | 0 | 90 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Verify | 51 | 0 | 21 | 0 | 72 | ✅ | | Create | 135 | 0 | 23 | 0 | 158 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Govern | 79 | 0 | 13 | 0 | 92 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Secure | 5 | 0 | 3 | 0 | 8 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 427 | 0 | 129 | 0 | 556 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 590f588bexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 84 | 0 | 10 | 0 | 94 | ✅ | | Create | 140 | 0 | 22 | 0 | 162 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Verify | 52 | 0 | 20 | 0 | 72 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Package | 29 | 0 | 15 | 0 | 44 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Secure | 3 | 0 | 5 | 0 | 8 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 445 | 0 | 127 | 0 | 572 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by ****started a merge train
See where you rank! Check your spot on the contributor leaderboard and unlock rewards.
How was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Request access to our community forks to receive complimentary access to GitLab Duo, our AI-powered features. With Code Suggestions, Chat, Root Cause Analysis and more AI-powered features, GitLab Duo helps to boost your efficiency and effectiveness by reducing the time required to write and understand code and pipelines. Visit the GitLab Duo documentation to learn more about the benefits.
Thanks for your help!
This message was generated automatically. Improve it or delete it.
- React with a
mentioned in commit ec56638b
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
changed milestone to %17.10