Skip to content

Home work - SDET interview technical evaluation

Tiffany Rea requested to merge tiffytester/gitlab:home_work into master

What does this MR do?

Screenshots

Screen_Shot_2019-10-01_at_11.21.56_AM

Screen_Shot_2019-10-01_at_11.22.07_AM

Does this MR meet the acceptance criteria?

This MR satisfied most requirements except for 5. As the "developer-user" user, create a merge request (MR) and assign it to the "root" user for review.

I wrote down some note as comment within the file for later discussion.

Conformity

Performance and Testing

No I dont think there is any risk to this. And no cross browser testing in here.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports