Home work - SDET interview technical evaluation
What does this MR do?
Screenshots
Does this MR meet the acceptance criteria?
This MR satisfied most requirements except for 5. As the "developer-user" user, create a merge request (MR) and assign it to the "root" user for review.
I wrote down some note as comment within the file for later discussion.
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines - [/] Style guides
-
Database guides -
Separation of EE specific content
Performance and Testing
No I dont think there is any risk to this. And no cross browser testing in here.
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team