Skip to content

Improve the only/except extendable jobs

Rémy Coutable requested to merge improve-review-only-except into master

What does this MR do?

  1. Factorize the
    variables:
      - $CI_SERVER_HOST == "gitlab.com" && $CI_PROJECT_NAMESPACE == "gitlab-org"
    into a new .only:variables-canonical-dot-com extensible job.
  2. Extract kubernetes: active to a new .only:kubernetes extensible job.
  3. Rename .only-canonical-schedules to .only:variables_refs-canonical-dot-com-schedules and make it extend from .only:variables-canonical-dot-com.
  4. Extract
    except:
      refs:
        - /^\d+-\d+-auto-deploy-\d+$/
    to a new .except:refs-deploy extensible job.
  5. Extract
    except:
      refs:
        - master
        - tags
      variables:
        - $CI_COMMIT_REF_NAME =~ /^[\d-]+-stable(-ee)?$/
    to a new .except:refs-master-tags-stable-deploy extensible job.
  6. Use the new extensible jobs where possible.
  7. Use the .keyword:attribute-description-of-the-job convention, e.g. .except:refs-deploy only includes the except keyword, with the refs attributes, and it's description is deploy.
Edited by Rémy Coutable

Merge request reports