Disable remove button for billable members pending removal on subsequent page visits
What does this MR do and why?
This MR introduces Local Storage functionality with expiration time in the Usage Quotas Seats members list. The reason is we improve consistency between the BE and the FE state of the application. When a billable member is scheduled for deletion, we assume that they will be removed from the group in the next 5 minutes. During that time, we show the member has pending deletion.
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
 
|
removed_billable_user_storage |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #515460 (closed)
Merge request reports
Activity
changed milestone to %17.9
assigned to @agulina
added docs-only label
added 1 commit
- 1bae9fe3 - Store recently delete billable members to ease the sync up
added 1 commit
- 1217e92f - Store recently delete billable members to ease the sync up
removed docs-only label
added 1 commit
- 38a6986e - Store recently delete billable members to ease the sync up
added 193 commits
-
38a6986e...759890e5 - 192 commits from branch
master - 1e05ec11 - Store recently delete billable members to ease the sync up
-
38a6986e...759890e5 - 192 commits from branch
added 1 commit
- 37dada73 - Store recently delete billable members to ease the sync up
added 1 commit
- 9314c840 - Store recently delete billable members to ease the sync up
added 1 commit
- 7b3f58f1 - Store recently delete billable members to ease the sync up
added 1 commit
- 2ce34478 - Store recently delete billable members to ease the sync up
added 1 commit
- 560f4425 - Store recently delete billable members to ease the sync up
added 1 commit
- d61011fe - Store recently delete billable members to ease the sync up
added 1 commit
- 58089ed4 - Store recently delete billable members to ease the sync up
added 1 commit
- 5769af5c - Store recently delete billable members to ease the sync up
added frontend label
2 Warnings 
featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request changed files with disabled eslint rules. Please consider fixing them. Disabled eslint rules
The following files have disabled
eslintrules. Please consider fixing them:ee/app/assets/javascripts/usage_quotas/seats/components/subscription_user_list.vue
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'ee/app/assets/javascripts/usage_quotas/seats/components/subscription_user_list.vue'Reviewer roulette
Category Reviewer Maintainer frontend @glin5(UTC-5, 6 hours behind author)
@slashmanov(UTC+4, 3 hours ahead of author)
UX @timnoah(UTC+0, 1 hour behind author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by ****added 1 commit
- f01b5829 - Store recently delete billable members to ease the sync up
- Resolved by Angelo Gulina
Hey @jmontal,
would you have time to look at this merge request, please? Thanks!
- Last reply by Angelo Gulina
requested review from @jmontal
- Resolved by Angelo Gulina
Hey @timnoah,
would you have time to look at this merge request, please? Thanks!
- Last reply by Tim Noah
requested review from @timnoah
added 1 commit
- 6499f0c2 - Store recently delete billable members to ease the sync up
added 1 commit
- ec7c1632 - Store recently delete billable members to ease the sync up
removed review request for @jmontal
requested review from @aalakkad
added 1 commit
- 39deab02 - Store recently delete billable members to ease the sync up
added 1 commit
- fb709604 - Store recently delete billable members to ease the sync up
requested review from @ohoral
added pipeline:mr-approved label
added pipelinetier-2 label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 957a845c and b679ef68
Entrypoint / Name Size before Size after Diff Diff in percent average 4.9 MB 4.9 MB - 0.0 % mainChunk 3.79 MB 3.79 MB - 0.0 %
Note: We do not have exact data for 957a845c. So we have used data from: 9050bdf9.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
E2E Test Result Summary
allure-report-publishergenerated test report!e2e-test-on-cng:
expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Package | 29 | 0 | 15 | 0 | 44 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Create | 140 | 0 | 22 | 0 | 162 | ✅ | | Verify | 52 | 0 | 20 | 0 | 72 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Govern | 83 | 0 | 11 | 0 | 94 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 443 | 0 | 128 | 0 | 571 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+e2e-test-on-gdk:
expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 82 | 0 | 8 | 0 | 90 | ✅ | | Create | 135 | 0 | 23 | 0 | 158 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Govern | 78 | 0 | 14 | 0 | 92 | ✅ | | Secure | 4 | 0 | 3 | 0 | 7 | ✅ | | Verify | 51 | 0 | 21 | 0 | 72 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 425 | 0 | 130 | 0 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+Edited by ****requested review from @ohoral and removed approval
added 1913 commits
-
5d8026a3...1cf397f2 - 1911 commits from branch
master - ba4b9ffe - Store recently delete billable members to ease the sync up
- b679ef68 - Add try/atch for extra safety
-
5d8026a3...1cf397f2 - 1911 commits from branch
started a merge train
mentioned in commit 94243d5e
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
