Skip to content
Snippets Groups Projects

Remove "Learn more." link from coverage check in MR approval rules

1 unresolved thread

What does this MR do and why?

Removed "Learn more" link from coverage check in MR approval rules.

#437677 (closed)

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before: image

After: image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Create a project / go to an existing project you own
  2. Go to Settings -> Merge Requests -> Scroll to Merge request approvals
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Solid work @peterhdangg!

    Just one small suggestion to fully cleanup the link usage in this file!

    Back to you :football:

  • Peter Dang added 1 commit

    added 1 commit

    • d7bee289 - removed unused vue injection

    Compare with previous version

  • Zack Cuddy resolved all threads

    resolved all threads

  • Zack Cuddy approved this merge request

    approved this merge request

  • Zack Cuddy enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • added frontend label

  • 3 Warnings
    :warning: d7bee289: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.
    :warning: The master pipeline status page reported failures in

    If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
    Please check for any on-going incidents in the incident issue tracker or in the #master-broken Slack channel.

    :warning: You've made some app changes, but didn't add any tests.
    That's OK as long as you're refactoring existing code,
    but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.
    1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Category Reviewer Maintainer
    frontend @thutterer profile link current availability (UTC+1) @ohoral profile link current availability (UTC+1)

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 9011c792 and d7bee289

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.43 MB 4.43 MB - 0.0 %
    mainChunk 3.29 MB 3.29 MB - 0.0 %

    Note: We do not have exact data for 9011c792. So we have used data from: 1cf60f9e.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-cng: :white_check_mark: test report for d7bee289

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 143    | 0      | 19      | 0     | 162   | ✅     |
    | Govern      | 84     | 0      | 10      | 0     | 94    | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Verify      | 53     | 0      | 19      | 0     | 72    | ✅     |
    | Package     | 29     | 0      | 15      | 0     | 44    | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 448    | 0      | 123     | 0     | 571   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-gdk: :white_check_mark: test report for d7bee289

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Create      | 138    | 0      | 20      | 0     | 158   | ✅     |
    | Plan        | 82     | 0      | 8       | 0     | 90    | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Verify      | 52     | 0      | 20      | 1     | 72    | ✅     |
    | Govern      | 79     | 0      | 13      | 0     | 92    | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Secure      | 4      | 0      | 3       | 0     | 7     | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 430    | 0      | 125     | 1     | 555   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    Edited by ****
  • merged

  • Hi @peterhdangg :wave:

    :tada: See where you rank! Check your spot on the contributor leaderboard and unlock rewards.


    How was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. React with a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    As a benefit of being a GitLab Community Contributor, you have access to GitLab Duo, our AI-powered features. With Code Suggestions, Chat, Root Cause Analysis and more AI-powered features, GitLab Duo helps to boost your efficiency and effectiveness by reducing the time required to write and understand code and pipelines. Visit the GitLab Duo documentation to learn more about the benefits.

    Thanks for your help! :heart:

    This message was generated automatically. Improve it or delete it.

  • Zack Cuddy mentioned in commit 8e62cd5f

    mentioned in commit 8e62cd5f

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading