Add DORA metrics dashboard MvC

assigned to @ekigbo

changed the description

Proper labels assigned to this merge request. Please ignore me.

@ekigbo - please see the following guidance and update this merge request.

	1 Error
	Please add typebug typefeature, or typemaintenance label to this merge request.

mentioned in merge request !177840 (merged)

added 232 commits

599368f7...e32e2378 - 224 commits from branch master
d2ec2815 - Add vsd_visualizations_in_analytics_dashboard_editor feature flag
9d9d0c19 - Fix failing rspec tests
a68d2168 - Exclude group only dashboards at the project level
305a870e - wip - align naming for DORA metric aggregated visualizations
cc961938 - wip - add df overtime line chart
e73811db - wip - render single stat
a1c9f51f - wip - basic deployment frequency over time
4df9bbce - wip - rename data source and update axis labels

Compare with previous version

added backend feature flag frontend groupoptimize labels

added devopsplan sectiondev labels

3 Warnings

ae7893b5: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.

featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

For more information, see:

The Handbook page on merge request types.
The definition of done documentation.

The master pipeline status page reported failures in

rspec system pg14 single-redis 8/32

If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the #master-broken Slack channel.

1 Message

CHANGELOG missing:

If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Category	Reviewer	Maintainer
backend	`@morefice` (UTC+1, 8 hours behind author)	`@dskim_gitlab` (UTC+11, 2 hours ahead of author)
frontend	`@fernando-c` (UTC-6, 15 hours behind author)	`@blabuschagne` (UTC+1, 8 hours behind author)
test for `spec/features/*`	`@morefice` (UTC+1, 8 hours behind author)	Maintainer review is optional for test for `spec/features/*`

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Generated by gitlab_quality-test_tooling.

Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

Click to expand

Job	File	Name	Duration	Expected duration
#8914935345	`ee/spec/features/groups/analytics/visualizations_spec.rb#L40`	Analytics Dashboard Visualizations for dora_chart visualization when ClickHouse is enabled for analytics when using project based historical statistics behaves like renders metrics comparison tables renders the Lifecycle metrics table	65.55 s	< 50.13 s
#8939913745	`ee/spec/features/groups/analytics/visualizations_spec.rb#L40`	Analytics Dashboard Visualizations for dora_chart visualization when ClickHouse is enabled for analytics when using project based historical statistics behaves like renders metrics comparison tables renders the Lifecycle metrics table	51.39 s	< 50.13 s
#9192490083	`ee/spec/features/groups/analytics/visualizations_spec.rb#L35`	Analytics Dashboard Visualizations for dora_chart visualization when ClickHouse is enabled for analytics behaves like renders metrics comparison tables renders the Lifecycle metrics table	51.08 s	< 50.13 s
#9221179443	`ee/spec/features/groups/analytics/visualizations_spec.rb#L35`	Analytics Dashboard Visualizations for dora_chart visualization when ClickHouse is enabled for analytics behaves like renders metrics comparison tables renders the Lifecycle metrics table	53.15 s	< 50.13 s
#9221517611	`ee/spec/features/groups/analytics/visualizations_spec.rb#L35`	Analytics Dashboard Visualizations for dora_chart visualization when ClickHouse is enabled for analytics behaves like renders metrics comparison tables renders the Lifecycle metrics table	53.85 s	< 50.13 s
#9228046589	`ee/spec/features/groups/analytics/visualizations_spec.rb#L35`	Analytics Dashboard Visualizations for dora_chart visualization when ClickHouse is enabled for analytics behaves like renders metrics comparison tables renders the Lifecycle metrics table	56.45 s	< 50.13 s

added rspec:slow test detected label

changed the description

changed milestone to %17.9

changed the description

@hsnir1 @blabuschagne @lvanc in Add DORA metrics over time datasource for Singl... (!151885 - merged) we added some single stat tiles for the four DORA metrics, these havent been expanded upon since they need to be manually configured, but with Include VSD panels in the built-in visualizatio... (#508776 - closed) they will be available to select from the list of visualizations to add to a dashboard.

This MR expands the data source to allow us to query both single values and time series data for the DORA metrics data source and adds relevant charts. I think this could be a first step towards replacing the CI/CD analytics page, at the very least it would provide some out of the box visualizations for DORA metrics. I made an example built in dashboard to illustrate their use.

There are a few ~ux issues, but it mostly works well, for example:

I hardcoded 180 days for testing, but should be able to easily support any of the options in the date range dropdown (although "today" wouldnt make a lot of sense for the chart)
The tooltip values dont get formatted correctly, so that will need a closer look
Currently no support for calculating the median/average lines, but this should not be too difficult
Connecting null values (the dotted lines in CI/CD analytics)
On the CI/CD analytics page, we use an Area chart for deployment frequency, but line chart for the others. I'm not sure why this is, but id be in favour of deciding on one chart type for consistency

For now, my main goal is to clean this up so that the single state and chart visualizations are useful out of the box, if we think the demo dashboard is worth having as well I can include that. Eitherway this provides a starting point for Create a new Value Stream Dashboards for DORA (#460158)

note: I would have expected on smaller screens that gridstack would respect the order the panels are defined in the config file, but it seems to use the X/Y positions instead. It would be good to have a defined (or overrideable) sort order.