Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 36,748
    • Issues 36,748
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,496
    • Merge Requests 1,496
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !17819

Merged
Created Sep 27, 2019 by Kamil Trzciński@ayufan🔴Maintainer4 of 4 tasks completed4/4 tasks

Improve exception handling

  • Overview 97
  • Commits 7
  • Pipelines 64
  • Changes 84

What does this MR do?

This is follow-up after gitlab-foss!23422 (closed).

This adds a new file: exceptions_json where we log all exceptions that are by user-required to be trackable, via Gitlab::Sentry.

This also improves a naming of the methods, as they are confusing:

  • from track_acceptable_exception => track_exception: we just want to capture exception

  • from track_exception => track_and_raise_for_dev_exception: as said,

  • from track_and_raise_exception => we want to capture and re-raise

Closes: #32906 (closed).

Does this MR meet the acceptance criteria?

Conformity

  • [-] Changelog entry
  • Documentation created/updated or follow-up review issue created
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • [-] Database guides
  • [-] Separation of EE specific content
Edited Dec 06, 2019 by Aleksei Lipniagov
Assignee
Assign to
Reviewer
Request review from
12.6
Milestone
12.6 (Past due)
Assign milestone
Time tracking
Source branch: improve-exception-handling