Use UTF-8 encoding for email notifications

Heinrich Lee Yurequested to merge
511320-emails-use-utf-8 into master

What does this MR do and why?

In gitlab-foss!26931 (merged), we forced US-ASCII to work around a bug in premailer-rails 1.10.x where it was setting the wrong encoding. See https://github.com/fphilipe/premailer-rails/issues/240 for more details.

We are now on premailer-rails 1.12.0 so forcing the encoding is no longer needed.

We are making this change to use UTF-8 encoding because we saw a self-managed instance have problems with the US-ASCII encoding. Their MTA or some mail processor was parsing these emails with HTML-encoded entities incorrectly and setting the wrong charset. We have tested this patch on the client's instance and it fixes the problem.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Heinrich Lee Yu

Merge request reports