Skip to content
Snippets Groups Projects

Include VSD panels in the built-in visualization list

Merged Ezekiel Kigbo requested to merge 508776-include-vsd-panels-in-dashboard-editor-list into master
All threads resolved!

What does this MR do and why?

This MR adds Value Stream Analytics (VSA) visualization panels to the built-in visualization list in the Analytics Dashboard Editor. The change enables users to access and utilize VSA panels directly within the analytics dashboard, improving the integration of Value Stream metrics visualization capabilities.

Screenshots

Before After - Group namespace After - Project namespace
Screenshot_2025-01-20_at_12.40.27 Screenshot_2025-01-21_at_22.14.33 Screenshot_2025-01-21_at_22.14.00

Key Changes and Actions

Change Description
Feature Flag Introduces vsd_visualizations_in_analytics_dashboard_editor feature flag
New Method Adds vsd_dashboard_editor_enabled? helper method
Visualization List Includes VSA panels in built-in visualizations when enabled
Testing Updates specs to account for additional VSA visualizations

References

  • Issue: #508776 (closed) - Value Stream Analytics panels in Analytics Dashboard Editor

MR acceptance checklist

  • Feature flag implementation follows GitLab standards
  • Test coverage added for new functionality
  • Documentation updated to reflect new features
  • Code follows established patterns for visualization integration

How to set up and validate locally

  1. Enable the feature flag in rails console:
    Feature.enable(:vsd_visualizations_in_analytics_dashboard_editor)
  2. Navigate to Analytics Dashboard Editor for a group or project
  3. Verify that VSA visualization panels are available in the built-in visualizations list
  4. Confirm that panels can be added to dashboards when the feature flag is enabled
  5. Test that panels are not visible when the feature flag is disabled
Edited by Ezekiel Kigbo

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Category Reviewer Maintainer
    backend @freinink profile link current availability (UTC-7, 18 hours behind author) @rzwambag profile link current availability (UTC+1, 10 hours behind author)

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by ****
  • Ezekiel Kigbo requested review from @GitLabDuo

    requested review from @GitLabDuo

  • I finished my review and found nothing to comment on. Nice work! :tada:

    · Leave feedback
    Edited by GitLab Duo
  • Ezekiel Kigbo
  • Ezekiel Kigbo resolved all threads

    resolved all threads

  • Ezekiel Kigbo added 1 commit

    added 1 commit

    • 23df8558 - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • Ezekiel Kigbo removed review request for @GitLabDuo

    removed review request for @GitLabDuo

  • Ezekiel Kigbo marked this merge request as ready

    marked this merge request as ready

  • Ezekiel Kigbo changed the description

    changed the description

  • Ezekiel Kigbo requested review from @apennells

    requested review from @apennells

  • added workflowin review label and removed workflowin dev label

  • Ezekiel Kigbo added 157 commits

    added 157 commits

    • 23df8558...fd4187b6 - 154 commits from branch master
    • d6fcc0c1 - Add vsd_visualizations_in_analytics_dashboard_editor feature flag
    • a64dd820 - Fix failing rspec tests
    • e1f03676 - wip - exclude group only dashboards at the project level

    Compare with previous version

  • Ezekiel Kigbo changed the description

    changed the description

  • Ezekiel Kigbo added 1 commit

    added 1 commit

    • b8f5bf30 - Exclude group only dashboards at the project level

    Compare with previous version

  • Alex Pennells
  • Alex Pennells
  • Ezekiel Kigbo added 1 commit

    added 1 commit

    • e6c3e680 - Exclude group only dashboards at the project level

    Compare with previous version

  • Ezekiel Kigbo added 227 commits

    added 227 commits

    • e6c3e680...e32e2378 - 224 commits from branch master
    • d2ec2815 - Add vsd_visualizations_in_analytics_dashboard_editor feature flag
    • 9d9d0c19 - Fix failing rspec tests
    • a68d2168 - Exclude group only dashboards at the project level

    Compare with previous version

  • Ezekiel Kigbo mentioned in issue #512464

    mentioned in issue #512464

  • mentioned in epic gitlab-org#16258

  • Ezekiel Kigbo requested review from @rliu-gl

    requested review from @rliu-gl

  • Alex Pennells approved this merge request

    approved this merge request

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Roy Liu approved this merge request

    approved this merge request

  • Roy Liu requested review from @rzwambag

    requested review from @rzwambag

  • Ezekiel Kigbo
  • Ezekiel Kigbo
  • Ezekiel Kigbo added 1 commit

    added 1 commit

    • f8e772d2 - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • Ezekiel Kigbo reset approvals from @apennells by pushing to the branch

    reset approvals from @apennells by pushing to the branch

  • :tools: Generated by gitlab_quality-test_tooling.


    :snail: Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

    Click to expand
    Job File Name Duration Expected duration
    #8926807202 ee/spec/features/groups/analytics/visualizations_spec.rb#L40 Analytics Dashboard Visualizations for dora_chart visualization when ClickHouse is enabled for analytics when using project based historical statistics behaves like renders metrics comparison tables renders the Lifecycle metrics table 53.01 s < 50.13 s
  • Roy Zwambag approved this merge request

    approved this merge request

  • Roy Zwambag resolved all threads

    resolved all threads

  • Roy Zwambag enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • merged

  • Roy Zwambag mentioned in commit 2e1b29e9

    mentioned in commit 2e1b29e9

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading