Include VSD panels in the built-in visualization list
What does this MR do and why?
This MR adds Value Stream Analytics (VSA) visualization panels to the built-in visualization list in the Analytics Dashboard Editor. The change enables users to access and utilize VSA panels directly within the analytics dashboard, improving the integration of Value Stream metrics visualization capabilities.
Screenshots
Before | After - Group namespace | After - Project namespace |
---|---|---|
![]() |
![]() |
![]() |
Key Changes and Actions
Change | Description |
---|---|
Feature Flag | Introduces vsd_visualizations_in_analytics_dashboard_editor feature flag |
New Method | Adds vsd_dashboard_editor_enabled? helper method |
Visualization List | Includes VSA panels in built-in visualizations when enabled |
Testing | Updates specs to account for additional VSA visualizations |
References
- Issue: #508776 (closed) - Value Stream Analytics panels in Analytics Dashboard Editor
MR acceptance checklist
-
Feature flag implementation follows GitLab standards -
Test coverage added for new functionality -
Documentation updated to reflect new features -
Code follows established patterns for visualization integration
How to set up and validate locally
- Enable the feature flag in rails console:
Feature.enable(:vsd_visualizations_in_analytics_dashboard_editor)
- Navigate to Analytics Dashboard Editor for a group or project
- Verify that VSA visualization panels are available in the built-in visualizations list
- Confirm that panels can be added to dashboards when the feature flag is enabled
- Test that panels are not visible when the feature flag is disabled
Merge request reports
Activity
changed milestone to %17.9
assigned to @ekigbo
added workflowin dev label and removed workflowready for development label
added pipelinetier-1 label
added feature flag label
added 758 commits
-
91dc0dae...5b2b7696 - 755 commits from branch
master
- b2ff9a41 - Add vsd_visualizations_in_analytics_dashboard_editor feature flag
- ada7073a - [skip ci] wip
- c4c711bc - [skip ci] wip
Toggle commit list-
91dc0dae...5b2b7696 - 755 commits from branch
added 279 commits
-
c4c711bc...0c6d22c6 - 275 commits from branch
master
- fc4e06ee - Add vsd_visualizations_in_analytics_dashboard_editor feature flag
- 9c07388e - [skip ci] wip
- 0d00ad9d - [skip ci] wip
- 4895dffc - Fix failing rspec tests
Toggle commit list-
c4c711bc...0c6d22c6 - 275 commits from branch
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-cng:
test report for f8e772d2expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Package | 30 | 0 | 14 | 0 | 44 | ✅ | | Verify | 51 | 0 | 19 | 0 | 70 | ✅ | | Plan | 82 | 0 | 8 | 0 | 90 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Create | 139 | 0 | 19 | 0 | 158 | ✅ | | Govern | 82 | 0 | 10 | 0 | 92 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 437 | 0 | 122 | 0 | 559 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-gdk:
test report for f8e772d2expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 100 | 0 | 40 | 2 | 140 | ✅ | | Create | 276 | 0 | 40 | 0 | 316 | ✅ | | Govern | 158 | 0 | 26 | 0 | 184 | ✅ | | Plan | 164 | 0 | 16 | 0 | 180 | ✅ | | Monitor | 16 | 0 | 24 | 0 | 40 | ✅ | | Release | 10 | 0 | 2 | 0 | 12 | ✅ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Data Stores | 66 | 0 | 20 | 0 | 86 | ✅ | | Package | 50 | 0 | 26 | 0 | 76 | ✅ | | Secure | 8 | 0 | 6 | 0 | 14 | ✅ | | Manage | 2 | 0 | 18 | 0 | 20 | ✅ | | Growth | 0 | 0 | 4 | 0 | 4 | ➖ | | Fulfillment | 4 | 0 | 14 | 0 | 18 | ✅ | | Ai-powered | 0 | 0 | 4 | 0 | 4 | ➖ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 858 | 0 | 248 | 2 | 1106 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for f8e772d2expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Fulfillment | 10 | 0 | 28 | 0 | 38 | ✅ | | Verify | 204 | 0 | 76 | 0 | 280 | ✅ | | Plan | 329 | 0 | 32 | 0 | 361 | ✅ | | Release | 20 | 0 | 4 | 0 | 24 | ✅ | | Create | 573 | 0 | 77 | 0 | 650 | ✅ | | Configure | 1 | 0 | 12 | 0 | 13 | ✅ | | Monitor | 36 | 0 | 49 | 0 | 85 | ✅ | | Govern | 355 | 0 | 32 | 0 | 387 | ✅ | | Manage | 32 | 0 | 44 | 1 | 76 | ✅ | | Data Stores | 145 | 0 | 41 | 0 | 186 | ✅ | | Package | 106 | 0 | 52 | 0 | 158 | ✅ | | Secure | 20 | 0 | 9 | 0 | 29 | ✅ | | Systems | 6 | 0 | 1 | 0 | 7 | ✅ | | Analytics | 9 | 0 | 0 | 0 | 9 | ✅ | | ModelOps | 0 | 0 | 4 | 0 | 4 | ➖ | | Growth | 0 | 0 | 8 | 0 | 8 | ➖ | | Ai-powered | 1 | 0 | 8 | 0 | 9 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 1849 | 0 | 478 | 1 | 2327 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+
Edited by ****- Resolved by Ezekiel Kigbo
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @freinink
(UTC-7, 18 hours behind author)
@rzwambag
(UTC+1, 10 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by ****requested review from @GitLabDuo
- Resolved by Ezekiel Kigbo
removed review request for @GitLabDuo
- Resolved by Alex Pennells
Hey @apennells would you be free to review this change?
I noticed we recently introduced the
group_analytics_dashboard_editor
feature flag.Did you intend all these changes to enable VSD visual editing to be done behind that? I'm just wondering if we really need this additional
vsd_visualizations_in_analytics_dashboard_editor
feature flag in the end?
requested review from @apennells
added workflowin review label and removed workflowin dev label
added 157 commits
-
23df8558...fd4187b6 - 154 commits from branch
master
- d6fcc0c1 - Add vsd_visualizations_in_analytics_dashboard_editor feature flag
- a64dd820 - Fix failing rspec tests
- e1f03676 - wip - exclude group only dashboards at the project level
Toggle commit list-
23df8558...fd4187b6 - 154 commits from branch
added 1 commit
- b8f5bf30 - Exclude group only dashboards at the project level
- Resolved by Alex Pennells
- Resolved by Alex Pennells
added 1 commit
- e6c3e680 - Exclude group only dashboards at the project level
added 227 commits
-
e6c3e680...e32e2378 - 224 commits from branch
master
- d2ec2815 - Add vsd_visualizations_in_analytics_dashboard_editor feature flag
- 9d9d0c19 - Fix failing rspec tests
- a68d2168 - Exclude group only dashboards at the project level
Toggle commit list-
e6c3e680...e32e2378 - 224 commits from branch
mentioned in issue #512464
mentioned in epic gitlab-org#16258
- Resolved by Roy Zwambag
Hi @rliu-gl would you be free to review this MR?
requested review from @rliu-gl
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
removed pipeline:run-e2e-omnibus-once label
requested review from @rzwambag
- Resolved by Ezekiel Kigbo
- Resolved by Ezekiel Kigbo
reset approvals from @apennells by pushing to the branch
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #8926807202 ee/spec/features/groups/analytics/visualizations_spec.rb#L40
Analytics Dashboard Visualizations for dora_chart visualization when ClickHouse is enabled for analytics when using project based historical statistics behaves like renders metrics comparison tables renders the Lifecycle metrics table 53.01 s < 50.13 s added rspec:slow test detected label
started a merge train
mentioned in commit 2e1b29e9
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label