Fix handling of short gzip metadata files
What does this MR do and why?
This backports !177221 (merged) to 17-7-stable-ee
.
Previously if a gzip file were less than 10 bytes, HttpIO#read(10)
would return a blank string instead of nil
. This could cause Zlib::GzipReader
to spin indefinitely, waiting for data that is not present.
Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/372134
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch. -
The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes). -
This MR has a severity label assigned (if applicable). -
Set the milestone of the merge request to match the target backport branch version. -
This MR has been approved by a maintainer (only one approval is required). -
Ensure the e2e:test-on-omnibus-ee
job has either succeeded or been approved by a Software Engineer in Test.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releases
Slack channel (internal only).
Edited by Max Fan