Fix handling of short gzip metadata files
What does this MR do and why?
Previously if a gzip file were less than 10 bytes, HttpIO#read(10)
would return a blank string instead of nil
. This could cause
Zlib::GzipReader
to spin indefinitely, waiting for data
that is not present.
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/372134
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.