Fix Group SAML Duo Add On assignment
What does this MR do and why?
Worker arguments were transposed causing the user ID and root namespace ID to be swapped, which could lead to incorrect assignment. This change fixes that problem and also adds more complete integration tests to catch problems in the future. Previously the tests stubbed the worker and were simply asserting that the worker was called, and it worked because the same incorrect transposition of arguments was used in the tests. Now, instead of stubbing we actually call the worker inline and assert that the assignment or unassignment worked.
This feature is behind a feature flag which has been disabled. To my knowledge, no syncing has actually occurred yet on GitLab.com.
Found while working on Duo Seat provision through SAML Group Sync for ... (#512141 - closed)
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.