Skip to content
Snippets Groups Projects

Switch populateAndUseBuildNamesTable feature flag on the FE

Merged Jose Ivan Vargas requested to merge jivanvl/switchJobNameFilterFF into master
1 unresolved thread

What does this MR do and why?

Switch the populateAndUseBuildNamesTable feature flag on the frontend.

This changes the aforementioned feature flag to feSearchBuildByName

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Max Fan
  • Reviewer roulette

    Category Reviewer Maintainer
    backend @zhaochen_li profile link current availability (UTC+11, 17 hours ahead of author) @msaleiko profile link current availability (UTC+1, 7 hours ahead of author)
    frontend @mcavoj profile link current availability (UTC+1, 7 hours ahead of author) @apennells profile link current availability (UTC-5, 1 hour ahead of author)
    ~"Verify" Reviewer review is optional for ~"Verify" @rkadam3 profile link current availability (UTC+5.5, 11.5 hours ahead of author)

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by ****
  • added 1 commit

    • 9ed64a60 - Switch populateAndUseBuildNamesTable feature flag on the FE

    Compare with previous version

  • Max Fan mentioned in merge request !177188 (closed)

    mentioned in merge request !177188 (closed)

  • Max Fan approved this merge request

    approved this merge request

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Author Maintainer

    @psimyn Can you please take a look? This just changes the name of the feature flag so we can switch the feature on the frontend and backend independently

  • Jose Ivan Vargas requested review from @psimyn

    requested review from @psimyn

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 10b7d562 and 9ed64a60

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.42 MB 4.42 MB - 0.0 %
    mainChunk 3.28 MB 3.28 MB - 0.0 %

    Note: We do not have exact data for 10b7d562. So we have used data from: a7797f45.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Simon Knox resolved all threads

    resolved all threads

  • Simon Knox approved this merge request

    approved this merge request

  • Simon Knox enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-cng: :white_check_mark: test report for 9ed64a60

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Govern      | 84     | 0      | 10      | 0     | 94    | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Create      | 140    | 0      | 19      | 0     | 159   | ✅     |
    | Verify      | 51     | 0      | 15      | 0     | 66    | ✅     |
    | Package     | 30     | 0      | 14      | 0     | 44    | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 444    | 0      | 118     | 0     | 562   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-gdk: :white_check_mark: test report for 9ed64a60

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 100    | 0      | 32      | 0     | 132   | ✅     |
    | Create      | 270    | 0      | 40      | 0     | 310   | ✅     |
    | Manage      | 2      | 0      | 18      | 0     | 20    | ✅     |
    | Data Stores | 66     | 0      | 20      | 0     | 86    | ✅     |
    | Plan        | 164    | 0      | 16      | 0     | 180   | ✅     |
    | Package     | 50     | 0      | 26      | 0     | 76    | ✅     |
    | Ai-powered  | 0      | 0      | 4       | 0     | 4     | ➖     |
    | Monitor     | 16     | 0      | 24      | 0     | 40    | ✅     |
    | Secure      | 8      | 0      | 6       | 0     | 14    | ✅     |
    | Release     | 10     | 0      | 2       | 0     | 12    | ✅     |
    | Analytics   | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Govern      | 160    | 0      | 24      | 0     | 184   | ✅     |
    | Fulfillment | 4      | 0      | 14      | 0     | 18    | ✅     |
    | Configure   | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Growth      | 0      | 0      | 4       | 0     | 4     | ➖     |
    | ModelOps    | 0      | 0      | 2       | 0     | 2     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 854    | 0      | 238     | 0     | 1092  | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    Edited by ****
  • Simon Knox added this merge request to the merge train at position 2

    added this merge request to the merge train at position 2

  • merged

  • Simon Knox mentioned in commit a05f5c09

    mentioned in commit a05f5c09

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading