Commit statuses api add filter on pipeline_id and sort
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you receive complimentary access to GitLab Duo.
What does this MR do and why?
- Filter commit statuses by pipeline id
- Sort commit statuses by asc and desc (today it is only asc) and ordered by id and pipeline_id (today only by id)
Signed-off-by: guillaume.micouin-jorda gmicouin@netcourrier.com
Merge request reports
Activity
added pipelinetier-1 label
Thanks for your contribution to GitLab @gmicouin!
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
- If you need help, page a coach by clicking here or come say hi on Discord.
- When you're ready, request a review by clicking here.
- We welcome AI-generated contributions and offer complimentary access to GitLab Duo!
- To add labels to your merge request, comment
@gitlab-bot label ~"label1" ~"label2"
.
This message was generated automatically. Improve it or delete it.
added Community contribution workflowin dev labels
assigned to @gmicouin
@gitlab-bot ready
Posted via contributors.gitlab.com.
added workflowready for review label and removed workflowin dev label
Hi
@brendan777
! Please review this documentation merge request. This message was generated automatically. Improve it or delete it.added documentation twtriaged labels
requested review from @brendan777
@brendan777, this Community contribution is ready for review.
- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
- Please ensure the group's Product Manager has validated the linked issue.
This message was generated automatically. Improve it or delete it.
- Resolved by Dmitry Gruzd
Thanks for these changes @gmicouin
I'm going to defer to Vasilii for the initial review.@vyaklushin, are you the right person to review these changes?
mentioned in issue gitlab-org/quality/triage-reports#21337 (closed)
requested review from @allison.browne
added grouppipeline execution label
added devopsverify sectionci labels
added Technical Writing label
requested review from @mfanGitLab and removed review request for @allison.browne
mentioned in issue gitlab-org/quality/triage-reports#21338 (closed)
mentioned in issue gitlab-org/developer-relations/contributor-success/team-task#713 (closed)
changed milestone to %17.8
- Resolved by Dmitry Gruzd
- Resolved by Dmitry Gruzd
- Resolved by Dmitry Gruzd
- Resolved by Dmitry Gruzd
- Resolved by Dmitry Gruzd
- Resolved by Dmitry Gruzd
This'll also need a database review as it's touching scopes. So far, it looks like they're still performant
https://console.postgres.ai/gitlab/gitlab-production-ci/sessions/34693/commands/107426 - order by id desc
https://console.postgres.ai/gitlab/gitlab-production-ci/sessions/34693/commands/107425 - order by id asc
https://console.postgres.ai/gitlab/gitlab-production-ci/sessions/34693/commands/107424 - commit_id asc
https://console.postgres.ai/gitlab/gitlab-production-ci/sessions/34693/commands/107423 - commit_id desc
@ck3g are you able to help the initial database review here?
Edited by Max Fan
requested review from @ck3g
- Resolved by Dmitry Gruzd
- Resolved by Dmitry Gruzd
mentioned in issue gitlab-org/quality/triage-reports#21383 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21436 (closed)
added featureaddition label
added typefeature label
@ck3g, @mfanGitLab, @brendan777, this Community contribution was recently assigned to you for review.
- Do you still have capacity to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
This message was generated automatically. You're welcome to improve it.
added automation:reviewers-reminded label
added workflowin dev label and removed workflowready for review label
removed automation:reviewers-reminded label
added database databasereview pending labels
added databasereviewed label and removed databasereview pending label
requested review from @pshutsin
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
added 1 commit
- dd526f56 - feat: Add the ability to sort commit statuses by id and pipeline_id
reset approvals from @ck3g by pushing to the branch
added 1 commit
- 17bbd931 - feat: Add the ability to sort commit statuses by id and pipeline_id
added 1 commit
- 555ea527 - feat: Add the ability to sort commit statuses by id and pipeline_id
added databaseapproved label and removed databasereviewed label
removed review request for @pshutsin
- Resolved by Dmitry Gruzd
requested review from @lyspin
added 1 commit
- 9834552a - feat: Add ability to filter and sort on commit statuses api to get statuses by pipeline id
reset approvals from @pshutsin by pushing to the branch
added 1 commit
- fc7c7eba - feat: Add ability to filter and sort on commit statuses api to get statuses by pipeline id
- Resolved by guillaume micouin
- Resolved by guillaume micouin
- Resolved by guillaume micouin
- Resolved by guillaume micouin
- Resolved by Dmitry Gruzd
@mfanGitLab Thanks for the ping!
@gmicouin I added a few documentation suggestions
Thank you!
- Resolved by Dmitry Gruzd
- Resolved by Dmitry Gruzd
- Resolved by Dmitry Gruzd
- Resolved by Dmitry Gruzd
removed review request for @brendan777
FYI: Removed myself as a reviewer because @lyspin has provided a TW review
added 1 commit
- 1745deb5 - Add ability to filter and sort on commit statuses api to get statuses by pipeline id
added backend label
- Resolved by Dmitry Gruzd
- Resolved by Dmitry Gruzd
1 Warning There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
2 Messages CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/commits.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer backend @charlieeekroon
(UTC+0)
@lulalala
(UTC+8)
database @dgruzd
(UTC+1)
@pshutsin
(UTC+1)
~"Verify" Reviewer review is optional for ~"Verify" @rkadam3
(UTC+5.5)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by ****-
documentation Changes LGTM! Approved
- Resolved by Dmitry Gruzd
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for f0ee085eexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 50 | 0 | 20 | 0 | 70 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Create | 138 | 0 | 20 | 0 | 158 | ✅ | | Plan | 82 | 0 | 8 | 0 | 90 | ✅ | | Govern | 80 | 0 | 12 | 0 | 92 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Package | 25 | 0 | 13 | 0 | 38 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Secure | 4 | 0 | 3 | 0 | 7 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 430 | 0 | 123 | 0 | 553 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for f0ee085eexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 84 | 0 | 10 | 0 | 94 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Create | 143 | 0 | 19 | 0 | 162 | ✅ | | Verify | 51 | 0 | 19 | 0 | 70 | ✅ | | Package | 30 | 0 | 14 | 0 | 44 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 447 | 0 | 122 | 0 | 569 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by ****added 1 commit
- 60d8f70c - Filter and sort commit statuses by pipeline id
added 1 commit
- 87d8f74f - Filter and sort commit statuses by pipeline id
added 1 commit
- 2589159b - Filter and sort commit statuses by pipeline id
added 1 commit
- a4141913 - Filter and sort commit statuses by pipeline id
added twfinished label and removed twtriaged label
requested review from @dgruzd
- Resolved by guillaume micouin
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
reset approvals from @lyspin by pushing to the branch
added 3 commits
-
6999176c...16dd5aee - 2 commits from branch
gitlab-org:master
- 0719179a - Filter and sort commit statuses by pipeline id
-
6999176c...16dd5aee - 2 commits from branch
- Resolved by Dmitry Gruzd
added 1 commit
- f0ee085e - Filter and sort commit statuses by pipeline id
reset approvals from @mfanGitLab by pushing to the branch
changed milestone to %17.9
requested review from @mfanGitLab
added this merge request to the merge train at position 2
@gmicouin, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Request access to our community forks to receive complimentary access to GitLab Duo, our AI-powered features. With Code Suggestions, Chat, Root Cause Analysis and more AI-powered features, GitLab Duo helps to boost your efficiency and effectiveness by reducing the time required to write and understand code and pipelines. Visit the GitLab Duo documentation to learn more about the benefits.
Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. Improve it or delete it.
- React with a
Hello @gmicouin
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. Improve it or delete it.
mentioned in commit 9139322a
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label