Skip to content
Snippets Groups Projects

Commit statuses api add filter on pipeline_id and sort

Merged guillaume micouin requested to merge gmicouin/gitlab:dev/gmic/status_pipeline_id into master
All threads resolved!

What does this MR do and why?

  • Filter commit statuses by pipeline id
  • Sort commit statuses by asc and desc (today it is only asc) and ordered by id and pipeline_id (today only by id)

Signed-off-by: guillaume.micouin-jorda gmicouin@netcourrier.com

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Max Fan
  • Max Fan
  • Max Fan
  • Max Fan requested review from @ck3g

    requested review from @ck3g

  • Max Fan
  • Max Fan
  • @ck3g, @mfanGitLab, @brendan777, this Community contribution was recently assigned to you for review.

    • Do you still have capacity to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
    • Add the workflowin dev label if the merge request needs action from the author.

    This message was generated automatically. You're welcome to improve it.

  • added workflowin dev label and removed workflowready for review label

  • Vitali Tatarintev approved this merge request

    approved this merge request

  • Vitali Tatarintev requested review from @pshutsin

    requested review from @pshutsin

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • added 1 commit

    • dd526f56 - feat: Add the ability to sort commit statuses by id and pipeline_id

    Compare with previous version

  • guillaume micouin reset approvals from @ck3g by pushing to the branch

    reset approvals from @ck3g by pushing to the branch

  • added 1 commit

    • 17bbd931 - feat: Add the ability to sort commit statuses by id and pipeline_id

    Compare with previous version

  • added 1 commit

    • 555ea527 - feat: Add the ability to sort commit statuses by id and pipeline_id

    Compare with previous version

  • Pavel Shutsin approved this merge request

    approved this merge request

  • added databaseapproved label and removed databasereviewed label

  • Pavel Shutsin removed review request for @pshutsin

    removed review request for @pshutsin

  • Max Fan
  • Max Fan requested review from @lyspin

    requested review from @lyspin

  • added 1 commit

    • 9834552a - feat: Add ability to filter and sort on commit statuses api to get statuses by pipeline id

    Compare with previous version

  • guillaume micouin reset approvals from @pshutsin by pushing to the branch

    reset approvals from @pshutsin by pushing to the branch

  • added 1 commit

    • fc7c7eba - feat: Add ability to filter and sort on commit statuses api to get statuses by pipeline id

    Compare with previous version

  • Lysanne Pinto
  • Lysanne Pinto
  • Lysanne Pinto requested changes

    requested changes

  • Max Fan
  • Max Fan
  • Max Fan
  • Max Fan
  • added 1 commit

    • f179b4be - Apply 4 suggestion(s) to 2 file(s)

    Compare with previous version

  • Brendan Lynch removed review request for @brendan777

    removed review request for @brendan777

  • FYI: Removed myself as a reviewer because @lyspin has provided a TW review :bow:

  • added 1 commit

    • 1745deb5 - Add ability to filter and sort on commit statuses api to get statuses by pipeline id

    Compare with previous version

  • Lysanne Pinto approved this merge request

    approved this merge request

  • **** added backend label

    added backend label

  • 1 Warning
    :warning: There were no new or modified feature flag YAML files detected in this MR.

    If the changes here are already controlled under an existing feature flag, please add
    the feature flagexists. Otherwise, if you think the changes here don't need
    to be under a feature flag, please add the label feature flagskipped, and
    add a short comment about why we skipped the feature flag.

    For guidance on when to use a feature flag, please see the documentation.

    2 Messages
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Category Reviewer Maintainer
    backend @charlieeekroon profile link current availability (UTC+0) @lulalala profile link current availability (UTC+8)
    database @dgruzd profile link current availability (UTC+1) @pshutsin profile link current availability (UTC+1)
    ~"Verify" Reviewer review is optional for ~"Verify" @rkadam3 profile link current availability (UTC+5.5)

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by ****
  • documentation Changes LGTM! Approved :thumbsup:

  • Max Fan
  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for f0ee085e

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 50     | 0      | 20      | 0     | 70    | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Create      | 138    | 0      | 20      | 0     | 158   | ✅     |
    | Plan        | 82     | 0      | 8       | 0     | 90    | ✅     |
    | Govern      | 80     | 0      | 12      | 0     | 92    | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Package     | 25     | 0      | 13      | 0     | 38    | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Secure      | 4      | 0      | 3       | 0     | 7     | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 430    | 0      | 123     | 0     | 553   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for f0ee085e

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Govern      | 84     | 0      | 10      | 0     | 94    | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Create      | 143    | 0      | 19      | 0     | 162   | ✅     |
    | Verify      | 51     | 0      | 19      | 0     | 70    | ✅     |
    | Package     | 30     | 0      | 14      | 0     | 44    | ✅     |
    | Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 447    | 0      | 122     | 0     | 569   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    Edited by ****
  • added 1 commit

    • 60d8f70c - Filter and sort commit statuses by pipeline id

    Compare with previous version

  • added 1 commit

    • 87d8f74f - Filter and sort commit statuses by pipeline id

    Compare with previous version

  • added 1 commit

    • 2589159b - Filter and sort commit statuses by pipeline id

    Compare with previous version

  • added 1 commit

    • a4141913 - Filter and sort commit statuses by pipeline id

    Compare with previous version

  • Lysanne Pinto added twfinished label and removed twtriaged label

    added twfinished label and removed twtriaged label

  • Max Fan approved this merge request

    approved this merge request

  • Max Fan requested review from @dgruzd

    requested review from @dgruzd

  • added 1 commit

    • 6a6448e8 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • guillaume micouin reset approvals from @lyspin by pushing to the branch

    reset approvals from @lyspin by pushing to the branch

  • added 2 commits

    • 24afe947 - Remove default on `group_saved_replies_flag feature flag
    • 6999176c - Filter and sort commit statuses by pipeline id

    Compare with previous version

  • added 3 commits

    Compare with previous version

  • Dmitry Gruzd
  • Dmitry Gruzd requested changes

    requested changes

  • added 1 commit

    • f0ee085e - Filter and sort commit statuses by pipeline id

    Compare with previous version

  • guillaume micouin reset approvals from @mfanGitLab by pushing to the branch

    reset approvals from @mfanGitLab by pushing to the branch

  • Dmitry Gruzd changed milestone to %17.9

    changed milestone to %17.9

  • Dmitry Gruzd approved this merge request

    approved this merge request

  • Dmitry Gruzd resolved all threads

    resolved all threads

  • Dmitry Gruzd requested review from @mfanGitLab

    requested review from @mfanGitLab

  • Lysanne Pinto approved this merge request

    approved this merge request

  • Max Fan approved this merge request

    approved this merge request

  • Max Fan resolved all threads

    resolved all threads

  • Max Fan enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Max Fan added this merge request to the merge train at position 2

    added this merge request to the merge train at position 2

  • merged

  • @gmicouin, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. React with a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Request access to our community forks to receive complimentary access to GitLab Duo, our AI-powered features. With Code Suggestions, Chat, Root Cause Analysis and more AI-powered features, GitLab Duo helps to boost your efficiency and effectiveness by reducing the time required to write and understand code and pipelines. Visit the GitLab Duo documentation to learn more about the benefits.

    Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

    Thanks for your help! :heart:

    This message was generated automatically. Improve it or delete it.

  • Hello @gmicouin :wave:

    The database team is looking for ways to improve the database review process and we would love your help!

    If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

    @gitlab-org/database-team

    And someone will be by shortly!

    Thanks for your help! :heart:

    This message was generated automatically. Improve it or delete it.

  • Max Fan mentioned in commit 9139322a

    mentioned in commit 9139322a

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading