Skip to content
Snippets Groups Projects

Handle 404s when fetching GitHub user details

Merged Luke Duncalfe requested to merge 508720-handle-404s into master

What does this MR do and why?

Handle 404s when fetching GitHub user details

The GitHub API can return a 404 when we try to fetch the user's details. We can see some errors when importing rails/rails. Specifically for the user Copilot.

We already have in place a fallback of using the GitHub username as the source user's name if we're unable to get the username from the API response.

This change does the same if we receive a 404 from the GitHub API.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Enable github_user_mapping feature flag.
  2. Conduct a GitHub import with user contributions from Copilot.
  3. The source user should be created successfully with user name "Copilot"

Related to #508720 (closed)

Edited by Luke Duncalfe

Merge request reports

Merge train pipeline #1592660258 passed

Merge train pipeline passed for 8f2fe17a

Merged by James NuttJames Nutt 3 months ago (Dec 17, 2024 3:06pm UTC)

Loading

Pipeline #1592661798 passed

Pipeline passed for c55cd09b on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading