Modify container registry project settings section with feature flag
What does this MR do and why?
Modify container registry project settings section with feature flag
Updates components to render card layout based on feature flag.
Also tweaking container registry cleanup policy temporarily so that it can be completed in Update the container registry cleanup setting t... (#503389 - closed)
Changelog is not required since these changes are under a feature flag.
Note: Since this MR is quite big already, changes are focused only on the Container registry section. Package registry section is being updated in Modify package registry project settings sectio... (!175357 - merged)
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
- Design: #500217[settings-expanded.png]
- We intend to update the container registry cleanup policy separately as part of #503389 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
With feature flag turned off | Before | After: with cleanup policy disabled | After: with cleanup policy enabled | After: with protected container rules |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
-
Setup container registry
-
Visit
Project > Settings > Packages and registries
. -
In rails console enable the experiment fully
Feature.enable(:reorganize_project_level_registry_settings)
-
To view protected containers, enable the feature flag
container_registry_protected_containers
-
Confirm that
Container registry
section looks like the one in screenshot & the settings are usable.
Related to #500217 (closed)
Merge request reports
Activity
changed milestone to %17.8
added Category:Container Registry Category:Package Registry Category:Virtual Registry Deliverable Package:P1 Technical Writing UI text UX automation:ml automation:self-triage-encouraged devopspackage featureenhancement frontend frontend-weight3 groupcontainer registry sectionci typefeature workflowin dev labels
assigned to @rchanila
added pipelinetier-1 label
3 Warnings ⚠️ This merge request is quite big (1001 lines changed), please consider splitting it into multiple merge requests. ⚠️ featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
⚠️ This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.1 Message 📖 CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/packages_and_registries/settings/project/components/container_expiration_policy.vue
+ <gl-card v-if="featureFlagEnabled" data-testid="container-expiration-policy-project-settings"> + data-testid="rules-button" + <p class="gl-text-subtle" data-testid="description"> + <p v-if="!isCleanupEnabled" data-testid="empty-cleanup-policy" class="gl-mb-0 gl-text-subtle">
app/assets/javascripts/packages_and_registries/settings/project/components/container_protection_rules.vue
+ data-testid="project-container-repository-protection-rules-settings" + data-testid="description" + data-testid="push-access-select" + data-testid="delete-btn"
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @jrushford
(UTC+1, 10 hours behind author)
@jerasmus
(UTC+1, 10 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerEdited by Ghost Usermentioned in merge request !175357 (merged)
added 1 commit
- 8d0b138c - Modify container registry project settings section with feature flag
- Resolved by Jacques Erasmus
- Resolved by Jacques Erasmus
- Resolved by Gina Doyle
- Resolved by Jacques Erasmus
- Resolved by Jacques Erasmus
- Resolved by Jacques Erasmus