Skip to content
Snippets Groups Projects

Re-add missing merge date tooltip to Vue MR list page

Merged Thomas Randolph requested to merge tor/defect/vue-mr-list-merged-at-tooltip into master

What does this MR do and why?

For part of #504362 (closed)

Adds a wee tooltip to the "Merged" badge on the MR list.

This tooltip is missing since the page was refactored from HAML to Vue.

The code does this by adding the tooltip to the generic issuable_item, but the value is only filled with some text (the timestamp) if the issuable has a mergedAt value, which should only exist for merged-state issuables (aka merged Merge Requests).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

The before image is showing no tooltip (or any hover effect at all).

Before After
image image

How to set up and validate locally

  1. Have a merged MR
  2. Go to the Merge Requests page
  3. Click the "Merged" tab
  4. Hover over the "Merged" badge
Edited by Thomas Randolph

Merge request reports

Merge train pipeline #1591528084 passed

Merge train pipeline passed for a2fb9c8b

Merged by Zack CuddyZack Cuddy 3 months ago (Dec 16, 2024 10:40pm UTC)

Loading

Pipeline #1591529296 passed

Pipeline passed for dd526ade on master

10 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading