Fix CreateService for buffered_token_expiration_limit
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you receive complimentary access to GitLab Duo.
What does this MR do and why?
This MR fixes an oversight when the buffered_token_expiration_limit feature flag and update was merged in Extend maximum token and SSH key expiration to ... (!153876 - merged)
The create service still used an explicit reference to the un-buffered length of a token. Update the CreateService to respect the feature flag.
Fix CreateService for buffered_token_expiration_limit
Update a place in the PAT creation where the buffered_token_expiration_limit feature flag was not being queried as tokens are being created.
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
- #508496 (closed)
- Additional updates to PAT buffered expiration flow (!175172 - merged)
- Extend maximum token and SSH key expiration to ... (!153876 - merged)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
See the linked issue for a cURL command which demonstrates the issue.