Extend maximum token and SSH key expiration to 400 days
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA
What does this MR do and why?
apps/settings: Extend maximum token and SSH key expiration to 400 days
An expiration of 365 days means that rotation ends up "creeping" back the calendar every year unless tokens are rotated on the exact day they expire. A forced "lose a day" occurs when the validity period spans over February 29th. In practice, the expiration falling on a weekend would also force losing a day or two. Instead, bump the maximum allowed to 400 days for all editions so that a little over one month of leeway is allowed to perform rotations of tokens and SSH keys.
While 395 would be "sufficient", 400 being so close makes it worth choosing instead.
Changelog: changed
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
N/A
How to set up and validate locally
Test suite should handle this.
Merge request reports
Activity
Thanks for your contribution to GitLab @ben.boeckel!
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
- If you need help, comment @gitlab-bot help or come say hi on Discord.
- When you're ready for a review, comment on this merge request with @gitlab-bot ready.
- We welcome AI-generated contributions! Read more/check the box at the top of the merge request description.
- To add labels to your merge request, comment @gitlab-bot label ~"label1" ~"label2".
This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @ben.boeckel
- Resolved by Ben Boeckel
tooling/bin/gettext_extractor locale/gitlab.pot
I tried running this in a container where I set up the require bits, but I can't seem to get
gettext-generator
for Node working.
- Resolved by Imre Farkas
@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
Hi
@msedlakjakubowski
! Please review this documentation merge request. This message was generated automatically. You're welcome to improve it.added documentation twtriaged labels
requested review from @msedlakjakubowski
@msedlakjakubowski
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
changed milestone to %17.1
added pipelinetier-1 label
added devopsgovern groupauthentication labels and removed pipelinetier-1 label
added pipelinetier-1 label
added sectionsec label
requested review from @hsutor and @adil.farrukh and removed review request for @msedlakjakubowski
added 1 commit
- 8b712e54 - apps/settings: Extend maximum token and SSH key expiration to 400 days
mentioned in issue #461782