Skip to content
Snippets Groups Projects

Backfill for Sharding Key on CI::BuildTraceMetadata

Merged Vlad Wolanyk requested to merge 458479-ci-build-trace-metadata-sharding-backfills into master
All threads resolved!

What does this MR do and why?

Add desired sharding key to Ci::BuildTraceMetadata (table p_ci_build_trace_metadata)

  • already had association that could reference sharding key: build_id
  • this table is partitioned and the new column is indexed accordingly
  • Check of production db shows no records with null build_id

https://console.postgres.ai/gitlab/gitlab-production-ci/sessions/34208/commands/105254

This table has a desired sharding key configured (view configuration).

This merge request is the first step towards transforming the desired sharding key into a sharding key.

This involves 4 changes:

  • Adding a new column that will serve as the sharding key (along with the relevant index and foreign key). ==> :project_id
  • Populating the sharding key when new records are created by adding a database function and trigger. (using a before_validation on: :create on the actual model)
  • indexing project_id on p_ci_build_trace_metadata
  • Scheduling a batched background migration to set the sharding key for existing records.

Once the background migration has completed, a second merge request will be created to finalize the background migration and validate the not null constraint.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #458479 (closed)

Edited by Vlad Wolanyk

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Vlad Wolanyk changed milestone to %17.7

    changed milestone to %17.7

  • assigned to @vwolanyk

  • 1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Category Reviewer Maintainer
    backend @schmil.monderer profile link current availability (UTC+2, 7 hours ahead of author) @pedropombeiro profile link current availability (UTC+1, 6 hours ahead of author)
    database @tachyons-gitlab profile link current availability (UTC+5.5, 10.5 hours ahead of author) @a_akgun profile link current availability (UTC+3, 8 hours ahead of author)
    ~"Verify" Reviewer review is optional for ~"Verify" @grzesiek profile link current availability (UTC+1, 6 hours ahead of author)

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Vlad Wolanyk changed the description

    changed the description

  • Vlad Wolanyk added 1 commit

    added 1 commit

    Compare with previous version

  • Database migrations (on the main database)

    Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

    Migration Type Total runtime Result DB size change
    20241204221832 - AddProjectIdToCiBuildTraceMetadata Regular 5.8 s :white_check_mark: +0.00 B
    20241204223047 - IndexCiBuildTraceMetadataOnProjectId Post deploy 7.6 s :white_check_mark: +32.00 KiB
    20241204223441 - QueueBackfillCiBuildTraceMetadataProjectId Post deploy 4.6 s :white_check_mark: +0.00 B
    Runtime Histogram for all migrations
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 0
    0.1 seconds - 1 second 14
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Migration: 20241204221832 - AddProjectIdToCiBuildTraceMetadata

    * Type: Regular
    * Duration: 5.8 s
    * Database size change: +0.00 B
    Calls Total Time Max Time Mean Time Rows Query
    1 4.5 ms 4.5 ms 4.5 ms 0
    ALTER TABLE "p_ci_build_trace_metadata" ADD "project_id" bigint
    1 0.7 ms 0.7 ms 0.7 ms 1
    SELECT "feature_gates"."key", "feature_gates"."value"  FROM "feature_gates"  WHERE "feature_gates"."feature_key" = $1
    2 0.0 ms 0.0 ms 0.0 ms 2
    SELECT pg_backend_pid()
    Histogram for AddProjectIdToCiBuildTraceMetadata
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 0
    0.1 seconds - 1 second 4
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Migration: 20241204223047 - IndexCiBuildTraceMetadataOnProjectId

    * Type: Post deploy
    * Duration: 7.6 s
    * Database size change: +32.00 KiB
    Calls Total Time Max Time Mean Time Rows Query
    1 5.9 ms 5.9 ms 5.9 ms 0
    CREATE INDEX CONCURRENTLY "index_e1af6de348" ON "gitlab_partitions_dynamic"."ci_build_trace_metadata_101" ("project_id")
    1 5.0 ms 5.0 ms 5.0 ms 0
    CREATE INDEX CONCURRENTLY "index_a6eb2f5ed8" ON "gitlab_partitions_dynamic"."ci_build_trace_metadata_100" ("project_id")
    1 4.4 ms 4.4 ms 4.4 ms 0
    CREATE INDEX CONCURRENTLY "index_cffd1f97fa" ON "gitlab_partitions_dynamic"."ci_build_trace_metadata_102" ("project_id")
    1 4.3 ms 4.3 ms 4.3 ms 3
    SELECT "postgres_partitions".*
    FROM "postgres_partitions" WHERE "postgres_partitions"."parent_identifier" = $1
    ORDER BY "postgres_partitions"."name" ASC
    1 2.0 ms 2.0 ms 2.0 ms 0
    CREATE INDEX "index_p_ci_build_trace_metadata_on_project_id" ON "p_ci_build_trace_metadata" ("project_id")
    1 0.5 ms 0.5 ms 0.5 ms 1
    SELECT "postgres_partitioned_tables".*
    FROM "postgres_partitioned_tables" WHERE (identifier = concat(current_schema(), $1, $2))
    LIMIT $3
    2 0.0 ms 0.0 ms 0.0 ms 2
    SELECT pg_backend_pid()
    Histogram for IndexCiBuildTraceMetadataOnProjectId
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 0
    0.1 seconds - 1 second 8
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Migration: 20241204223441 - QueueBackfillCiBuildTraceMetadataProjectId

    * Type: Post deploy
    * Duration: 4.6 s
    * Database size change: +0.00 B
    Calls Total Time Max Time Mean Time Rows Query
    2 0.0 ms 0.0 ms 0.0 ms 2
    SELECT pg_backend_pid()
    Histogram for QueueBackfillCiBuildTraceMetadataProjectId
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 0
    0.1 seconds - 1 second 2
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Background Migration: BackfillIssueEmailsNamespaceId

    Sampled 40 batches. Estimated Time to complete: 2 days, 11 hours, and 52 minutes
    • Interval: 120s
    • Max batch size: 0
    • Estimated seconds to complete: 215520s
    • Average batch time: 5.17s
    • Batch size: 1000
    • N. of batches sampled: 40
    • N. of failed batches: 0

    Time estimation is conservative and based on sampling production data in a test environment. It represents the max time that migration could take. The actual time may differ from this estimation.

    Consider changing max_batch_size and interval if this estimate is unacceptable.

    Calls Total Time Max Time Mean Time Rows Query
    351 7629.8 ms 149.7 ms 21.7 ms 22013
    UPDATE issue_emails
    SET namespace_id = issues.namespace_id
    FROM issues
    WHERE issues.id = issue_emails.issue_id AND issue_emails.id IN (
    SELECT issue_emails.id
    FROM issue_emails
    WHERE issue_emails.id BETWEEN $1 AND $2 AND issue_emails.id >= $3 AND issue_emails.id < $4 AND issue_emails.namespace_id IS NULL
    )
    40 847.7 ms 133.4 ms 21.2 ms 2402
    UPDATE issue_emails
    SET namespace_id = issues.namespace_id
    FROM issues
    WHERE issues.id = issue_emails.issue_id AND issue_emails.id IN (
    SELECT issue_emails.id
    FROM issue_emails
    WHERE issue_emails.id BETWEEN $1 AND $2 AND issue_emails.id >= $3 AND issue_emails.namespace_id IS NULL
    )
    80 14.6 ms 4.2 ms 0.2 ms 80
    INSERT INTO batched_background_migration_job_transition_logs (batched_background_migration_job_id, created_at, updated_at, previous_status, next_status) VALUES ($1, $2, $3, $4, $5) RETURNING id
    391 65.9 ms 0.5 ms 0.2 ms 351
    SELECT issue_emails.id
    FROM issue_emails
    WHERE issue_emails.id BETWEEN $1 AND $2 AND issue_emails.id >= $3
    ORDER BY issue_emails.id ASC
    LIMIT $4
    OFFSET $5
    40 5.6 ms 0.3 ms 0.1 ms 40
    UPDATE batched_background_migration_jobs
    SET updated_at = $1, finished_at = $2, status = $3, metrics = $4
    WHERE batched_background_migration_jobs.id = $5
    40 4.8 ms 0.2 ms 0.1 ms 40
    UPDATE batched_background_migration_jobs
    SET updated_at = $1, started_at = $2, status = $3, attempts = $4
    WHERE batched_background_migration_jobs.id = $5
    80 3.3 ms 0.1 ms 0.0 ms 80
    SELECT batched_background_migration_jobs.*
    FROM batched_background_migration_jobs
    WHERE batched_background_migration_jobs.id = $1
    LIMIT $2
    40 2.3 ms 0.1 ms 0.1 ms 40
    SELECT sum(batched_background_migration_jobs.batch_size)
    FROM batched_background_migration_jobs
    WHERE batched_background_migration_jobs.batched_background_migration_id = $1 AND batched_background_migration_jobs.status IN ($2)
    40 1.4 ms 0.0 ms 0.0 ms 40
    SELECT issue_emails.id
    FROM issue_emails
    WHERE issue_emails.id BETWEEN $1 AND $2
    ORDER BY issue_emails.id ASC
    LIMIT $3
    Histogram of batch runtimes for BackfillIssueEmailsNamespaceId
    Batch Runtime Count
    0 seconds - 10 seconds 40
    10 seconds - 1 minute 0
    1 minute - 2 minutes 0
    2 minutes - 3 minutes 0
    3 minutes - 5 minutes 0
    5 minutes + 0
    Histogram across all sampled batches of BackfillIssueEmailsNamespaceId
    Query Runtime Count
    0 seconds - 0.1 seconds 0
    0.1 seconds - 0.5 seconds 1102
    0.5 seconds - 1 second 0
    1 second - 2 seconds 0
    2 seconds - 5 seconds 0
    5 seconds + 0
    #### Other information
    Other migrations pending on GitLab.com
    Migration Type Total runtime Result DB size change
    20241203080306 - IndexIssueEmailsOnNamespaceId Post deploy 6.7 s :white_check_mark: +11.90 MiB
    20241203080307 - AddIssueEmailsNamespaceIdFk Post deploy 5.7 s :white_check_mark: +0.00 B
    20241203080308 - AddIssueEmailsNamespaceIdTrigger Post deploy 4.9 s :white_check_mark: +0.00 B
    20241203080309 - QueueBackfillIssueEmailsNamespaceId Post deploy 5.8 s :white_check_mark: +0.00 B
    Clone details
    Clone ID Clone Created At Clone Data Timestamp Expected Removal Time
    database-testing-3959382-16351786-main 2024-12-06T18:40:47Z 2024-12-05T07:19:25Z 2024-12-07 07:03:41 +0000
    database-testing-3959382-16351786-ci 2024-12-06T18:40:46Z 2024-12-06T16:58:14Z 2024-12-07 07:03:41 +0000

    Job artifacts

    Database migrations (on the ci database)

    Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

    Migration Type Total runtime Result DB size change
    20241204221832 - AddProjectIdToCiBuildTraceMetadata Regular 8.3 s :white_check_mark: +0.00 B
    20241204223047 - IndexCiBuildTraceMetadataOnProjectId Post deploy 281.5 s :white_check_mark: +1.79 GiB
    20241204223441 - QueueBackfillCiBuildTraceMetadataProjectId Post deploy 8.7 s :white_check_mark: +0.00 B
    Runtime Histogram for all migrations
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 0
    0.1 seconds - 1 second 16
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 1
    5 minutes + 0

    Migration: 20241204221832 - AddProjectIdToCiBuildTraceMetadata

    * Type: Regular
    * Duration: 8.3 s
    * Database size change: +0.00 B
    Calls Total Time Max Time Mean Time Rows Query
    1 4.5 ms 4.5 ms 4.5 ms 0
    ALTER TABLE "p_ci_build_trace_metadata" ADD "project_id" bigint
    2 0.0 ms 0.0 ms 0.0 ms 2
    SELECT pg_backend_pid()
    Histogram for AddProjectIdToCiBuildTraceMetadata
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 0
    0.1 seconds - 1 second 3
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Migration: 20241204223047 - IndexCiBuildTraceMetadataOnProjectId

    * Type: Post deploy
    * Duration: 281.5 s
    * Database size change: +1.79 GiB
    Calls Total Time Max Time Mean Time Rows Query
    1 270133.4 ms 270133.4 ms 270133.4 ms 0
    CREATE INDEX CONCURRENTLY "index_cffd1f97fa" ON "gitlab_partitions_dynamic"."ci_build_trace_metadata_102" ("project_id")
    1 264.3 ms 264.3 ms 264.3 ms 0
    CREATE INDEX CONCURRENTLY "index_e1af6de348" ON "gitlab_partitions_dynamic"."ci_build_trace_metadata_101" ("project_id")
    1 56.6 ms 56.6 ms 56.6 ms 0
    CREATE INDEX CONCURRENTLY "index_a6eb2f5ed8" ON "gitlab_partitions_dynamic"."ci_build_trace_metadata_100" ("project_id")
    1 4.6 ms 4.6 ms 4.6 ms 0
    CREATE INDEX "index_p_ci_build_trace_metadata_on_project_id" ON "p_ci_build_trace_metadata" ("project_id")
    1 3.7 ms 3.7 ms 3.7 ms 3
    SELECT "postgres_partitions".*
    FROM "postgres_partitions" WHERE "postgres_partitions"."parent_identifier" = $1
    ORDER BY "postgres_partitions"."name" ASC
    1 0.2 ms 0.2 ms 0.2 ms 1
    SELECT "postgres_partitioned_tables".*
    FROM "postgres_partitioned_tables" WHERE (identifier = concat(current_schema(), $1, $2))
    LIMIT $3
    2 0.0 ms 0.0 ms 0.0 ms 2
    SELECT pg_backend_pid()
    Histogram for IndexCiBuildTraceMetadataOnProjectId
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 0
    0.1 seconds - 1 second 7
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 1
    5 minutes + 0

    Migration: 20241204223441 - QueueBackfillCiBuildTraceMetadataProjectId

    * Type: Post deploy
    * Duration: 8.7 s
    * Database size change: +0.00 B
    Calls Total Time Max Time Mean Time Rows Query
    1 7.5 ms 7.5 ms 7.5 ms 1
    SELECT MAX("build_id")
    FROM "p_ci_build_trace_metadata"
    1 7.2 ms 7.2 ms 7.2 ms 1
    INSERT INTO "batched_background_migrations" ("created_at", "updated_at", "max_value", "batch_size", "sub_batch_size", "interval", "status", "job_class_name", "table_name", "column_name", "job_arguments", "total_tuple_count", "started_at", "gitlab_schema", "queued_migration_version") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15) RETURNING "id"
    1 1.7 ms 1.7 ms 1.7 ms 0
    SELECT $1 AS one
    FROM "batched_background_migrations" WHERE "batched_background_migrations"."job_arguments" = $2 AND "batched_background_migrations"."job_class_name" = $3 AND "batched_background_migrations"."table_name" = $4 AND "batched_background_migrations"."column_name" = $5
    LIMIT $6
    1 0.9 ms 0.9 ms 0.9 ms 0
    SELECT $1 AS one
    FROM "batched_background_migrations" WHERE "batched_background_migrations"."job_class_name" = $2 AND "batched_background_migrations"."table_name" = $3 AND "batched_background_migrations"."column_name" = $4 AND (job_arguments = $5) AND "batched_background_migrations"."gitlab_schema" = $6
    LIMIT $7
    2 0.0 ms 0.0 ms 0.0 ms 2
    SELECT pg_backend_pid()
    Histogram for QueueBackfillCiBuildTraceMetadataProjectId
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 0
    0.1 seconds - 1 second 6
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Background Migration: BackfillCiBuildTraceMetadataProjectId

    Sampled 2 batches. Estimated Time to complete: 2 weeks, 1 day, 4 hours, and 50 minutes
    • Interval: 120s
    • Max batch size: 0
    • Estimated seconds to complete: 1313400s
    • Average batch time: 51.14s
    • Batch size: 25000
    • N. of batches sampled: 2
    • N. of failed batches: 0

    Time estimation is conservative and based on sampling production data in a test environment. It represents the max time that migration could take. The actual time may differ from this estimation.

    Consider changing max_batch_size and interval if this estimate is unacceptable.

    Calls Total Time Max Time Mean Time Rows Query
    166 40303.7 ms 635.8 ms 242.8 ms 24900
    UPDATE p_ci_build_trace_metadata
    SET project_id = p_ci_builds.project_id
    FROM p_ci_builds
    WHERE p_ci_builds.id = p_ci_build_trace_metadata.build_id AND p_ci_builds.partition_id = p_ci_build_trace_metadata.partition_id AND p_ci_build_trace_metadata.build_id IN (
    SELECT p_ci_build_trace_metadata.build_id
    FROM p_ci_build_trace_metadata
    WHERE p_ci_build_trace_metadata.build_id BETWEEN $1 AND $2 AND p_ci_build_trace_metadata.build_id >= $3 AND p_ci_build_trace_metadata.build_id < $4 AND p_ci_build_trace_metadata.project_id IS NULL
    )
    2 199.3 ms 179.3 ms 99.7 ms 101
    UPDATE p_ci_build_trace_metadata
    SET project_id = p_ci_builds.project_id
    FROM p_ci_builds
    WHERE p_ci_builds.id = p_ci_build_trace_metadata.build_id AND p_ci_builds.partition_id = p_ci_build_trace_metadata.partition_id AND p_ci_build_trace_metadata.build_id IN (
    SELECT p_ci_build_trace_metadata.build_id
    FROM p_ci_build_trace_metadata
    WHERE p_ci_build_trace_metadata.build_id BETWEEN $1 AND $2 AND p_ci_build_trace_metadata.build_id >= $3 AND p_ci_build_trace_metadata.project_id IS NULL
    )
    2 10.4 ms 10.3 ms 5.2 ms 2
    UPDATE batched_background_migration_jobs
    SET updated_at = $1, finished_at = $2, status = $3, metrics = $4
    WHERE batched_background_migration_jobs.id = $5
    4 8.9 ms 8.4 ms 2.2 ms 4
    INSERT INTO batched_background_migration_job_transition_logs (batched_background_migration_job_id, created_at, updated_at, previous_status, next_status) VALUES ($1, $2, $3, $4, $5) RETURNING id
    168 64.1 ms 1.1 ms 0.4 ms 166
    SELECT p_ci_build_trace_metadata.build_id
    FROM p_ci_build_trace_metadata
    WHERE p_ci_build_trace_metadata.build_id BETWEEN $1 AND $2 AND p_ci_build_trace_metadata.build_id >= $3
    ORDER BY p_ci_build_trace_metadata.build_id ASC
    LIMIT $4
    OFFSET $5
    2 0.2 ms 0.1 ms 0.1 ms 2
    UPDATE batched_background_migration_jobs
    SET updated_at = $1, started_at = $2, status = $3, attempts = $4
    WHERE batched_background_migration_jobs.id = $5
    4 0.2 ms 0.1 ms 0.0 ms 4
    SELECT batched_background_migration_jobs.*
    FROM batched_background_migration_jobs
    WHERE batched_background_migration_jobs.id = $1
    LIMIT $2
    2 0.0 ms 0.0 ms 0.0 ms 2
    SELECT sum(batched_background_migration_jobs.batch_size)
    FROM batched_background_migration_jobs
    WHERE batched_background_migration_jobs.batched_background_migration_id = $1 AND batched_background_migration_jobs.status IN ($2)
    2 0.0 ms 0.0 ms 0.0 ms 2
    SELECT p_ci_build_trace_metadata.build_id
    FROM p_ci_build_trace_metadata
    WHERE p_ci_build_trace_metadata.build_id BETWEEN $1 AND $2
    ORDER BY p_ci_build_trace_metadata.build_id ASC
    LIMIT $3
    Histogram of batch runtimes for BackfillCiBuildTraceMetadataProjectId
    Batch Runtime Count
    0 seconds - 10 seconds 1
    10 seconds - 1 minute 0
    1 minute - 2 minutes 1
    2 minutes - 3 minutes 0
    3 minutes - 5 minutes 0
    5 minutes + 0
    Histogram across all sampled batches of BackfillCiBuildTraceMetadataProjectId
    Query Runtime Count
    0 seconds - 0.1 seconds 0
    0.1 seconds - 0.5 seconds 347
    0.5 seconds - 1 second 5
    1 second - 2 seconds 0
    2 seconds - 5 seconds 0
    5 seconds + 0
    #### Other information

    No other migrations pending on GitLab.com

    Clone details
    Clone ID Clone Created At Clone Data Timestamp Expected Removal Time
    database-testing-3959382-16351786-main 2024-12-06T18:40:47Z 2024-12-05T07:19:25Z 2024-12-07 07:03:41 +0000
    database-testing-3959382-16351786-ci 2024-12-06T18:40:46Z 2024-12-06T16:58:14Z 2024-12-07 07:03:41 +0000

    Job artifacts


    Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic

    Edited by ****
  • Vlad Wolanyk added 1 commit

    added 1 commit

    • fada75d8 - Add spec for setting project id

    Compare with previous version

  • Vlad Wolanyk marked this merge request as ready

    marked this merge request as ready

  • Pedro Pombeiro
  • Irina Bronipolsky
  • Vlad Wolanyk changed the description

    changed the description

  • Vlad Wolanyk added 1 commit

    added 1 commit

    Compare with previous version

  • added Stretch label

  • removed Deliverable label

  • Pedro Pombeiro
  • Vlad Wolanyk added 1242 commits

    added 1242 commits

    Compare with previous version

  • Vlad Wolanyk added 1 commit

    added 1 commit

    Compare with previous version

  • Pedro Pombeiro approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 0875e8ba

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Package     | 21     | 0      | 0       | 0     | 21    | ✅     |
    | Create      | 36     | 0      | 2       | 0     | 38    | ✅     |
    | Govern      | 26     | 0      | 2       | 0     | 28    | ✅     |
    | Verify      | 12     | 0      | 0       | 0     | 12    | ✅     |
    | Plan        | 16     | 0      | 0       | 0     | 16    | ✅     |
    | Data Stores | 17     | 0      | 0       | 0     | 17    | ✅     |
    | Analytics   | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Monitor     | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Secure      | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage      | 1      | 0      | 0       | 0     | 1     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 133    | 0      | 4       | 0     | 137   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for 0875e8ba

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Verify      | 49     | 0      | 16      | 0     | 65    | ✅     |
    | Create      | 140    | 0      | 19      | 0     | 159   | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Govern      | 84     | 0      | 10      | 0     | 94    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 436    | 0      | 119     | 0     | 555   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Irina Bronipolsky resolved all threads

    resolved all threads

  • Irina Bronipolsky approved this merge request

    approved this merge request

  • requested review from @DylanGriffith

  • mentioned in issue #458479 (closed)

  • Dylan Griffith approved this merge request

    approved this merge request

  • added databaseapproved label and removed databasereviewed label

  • Author Developer

    Thanks @DylanGriffith

    @pedropombeiro or @DylanGriffith could one of you merge this now that all required approvals have been given?

  • Pedro Pombeiro enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Hello @vwolanyk :wave:

    The database team is looking for ways to improve the database review process and we would love your help!

    If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

    @gitlab-org/database-team

    And someone will be by shortly!

    Thanks for your help! :heart:

    This message was generated automatically. Improve it or delete it.

  • Pedro Pombeiro mentioned in commit c3695b5c

    mentioned in commit c3695b5c

  • added workflowcomplete label and removed workflowin review label

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading