Fix accessibility violation in settings-block shared component
What does this MR do and why?
Fix accessibility violation in vue_shared/settings-block.vue
detected while adding specs in !174272 (merged)
Fixes aria-allowed-role
axe violation https://dequeuniversity.com/rules/axe/4.9/aria-allowed-role?application=axeAPI
Closes #507300 (closed)
Changelog: fixed
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
N/A
How to set up and validate locally
- Run
yarn storybook:start
- Verify the
settings block
story
Merge request reports
Activity
assigned to @rchanila
changed milestone to %17.7
added maintenancerefactor label
added typemaintenance label
added pipelinetier-1 label
added groupcontainer registry label and removed pipelinetier-1 typemaintenance labels
removed maintenancerefactor label
added devopspackage sectionci labels
added frontend label and removed devopspackage sectionci labels
added devopspackage sectionci labels
added maintenancerefactor label
added typemaintenance label
1 Warning This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.Reviewer roulette
Category Reviewer Maintainer frontend @dzubova
(UTC+1, 10 hours behind author)
@vitallium
(UTC+1, 10 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Scott de Jonge
@sdejonge could I get your review here please? TIA!
requested review from @sdejonge
added accessibility accessibilitylow labels
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 9b5f6cdc and 66eb77f8
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.48 MB 4.48 MB - 0.0 % mainChunk 3.37 MB 3.37 MB - 0.0 %
Note: We do not have exact data for 9b5f6cdc. So we have used data from: 1152f6f3.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels
reset approvals from @sdejonge by pushing to the branch
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 66eb77f8expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Package | 25 | 0 | 11 | 0 | 36 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 403 | 0 | 41 | 0 | 444 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 66eb77f8expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 140 | 0 | 20 | 0 | 160 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Fulfillment | 2 | 0 | 7 | 1 | 9 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 84 | 0 | 9 | 1 | 93 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 119 | 3 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
requested review from @sdejonge
started a merge train
mentioned in commit bf5afb08
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
mentioned in issue #500217 (closed)
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue #507300 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label