Skip to content
Snippets Groups Projects

Adds feature flag to reorganise project level registry settings

What does this MR do and why?

This MR adds new feature flag reorganize_project_level_registry_settings which will be used to reorganise project level registry settings.

This will be first of multiple MRs for this change, so limiting this MR to adding just the sections for package & container registry settings.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

With feature flag disabled With feature flag enabled
Screenshot_2024-12-02_at_11.05.52_PM Screenshot_2024-12-02_at_10.37.26_PM

How to set up and validate locally

  1. In rails console enable the experiment fully
    Feature.enable(:reorganize_project_level_registry_settings)
  2. Setup & enable Container Registry https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/registry.md
  3. Visit Project > Settings > Packages and registries.

Related to #500217 (closed)

Edited by Rahul Chanila

Merge request reports

Loading
Loading
  • 1 Warning
    :warning:

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Category Reviewer Maintainer
    backend @alexbuijs profile link current availability (UTC+1, 10 hours behind author) @seanarnold profile link current availability (UTC+13, 2 hours ahead of author)
    frontend @obaiye profile link current availability (UTC+1, 10 hours behind author) @djadmin profile link current availability (UTC+5.5, 5.5 hours behind author)
    test for spec/features/* @alexbuijs profile link current availability (UTC+1, 10 hours behind author) Maintainer review is optional for test for spec/features/*

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    Searchable setting sections

    Looks like you have edited the template of some settings section. Please check that all changed sections are still searchable:

    • If you created a new section, make sure to add it to either lib/search/project_settings.rb or lib/search/group_settings.rb, or in their counterparts in ee/ if this section is only available behind a licensed feature.
    • If you removed a section, make sure to also remove it from the files above.
    • If you changed a section's id, please update it also in the files above.
    • If you just moved code around within the same page, there is nothing to do.
    • If you are unsure what to do, please reach out to grouppersonal productivity.

    app/assets/javascripts/packages_and_registries/settings/project/components/container_registry_section.vue

    +  <settings-block
    +  </settings-block>

    app/assets/javascripts/packages_and_registries/settings/project/components/package_registry_section.vue

    +  <settings-block id="package-registry-settings" :title="s__('PackageRegistry|Package registry')">
    +  </settings-block>

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Rahul Chanila added 1 commit

    added 1 commit

    • b986cf91 - Adds feature flag to reorganise project level registry settings

    Compare with previous version

  • Rahul Chanila added 1 commit

    added 1 commit

    Compare with previous version

  • Rahul Chanila added 1 commit

    added 1 commit

    • 1ecbcfc4 - Adds feature flag to reorganise project level registry settings

    Compare with previous version

  • Rahul Chanila mentioned in commit c4cc0cde

    mentioned in commit c4cc0cde

  • Rahul Chanila mentioned in merge request !174321 (merged)

    mentioned in merge request !174321 (merged)

  • Rahul Chanila mentioned in commit bda71e93

    mentioned in commit bda71e93

  • Rahul Chanila added 280 commits

    added 280 commits

    • 1ecbcfc4...bf5afb08 - 277 commits from branch master
    • 504629fb - Adds feature flag to reorganise project level registry settings
    • ebf31bc2 - Update feature flag config
    • 90a9ae68 - Adds feature flag to reorganise project level registry settings

    Compare with previous version

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 53958fa9 and 4cb5a2c8

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.49 MB 4.49 MB - 0.0 %
    mainChunk 3.37 MB 3.37 MB - 0.0 %

    :fearful: Significant Growth: 1

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.projects.settings.packages_and_registries.show 533.6 KB 554.77 KB +21.18 KB 4.0 %

    Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

    Please consider pinging someone from the FE Foundations (@leipert, @markrian, @pgascouvaillancourt, @sdejonge or @thutterer) for review, if you are unsure about the size increase.

    Note: We do not have exact data for 53958fa9. So we have used data from: 814dec8e.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Rahul Chanila marked this merge request as ready

    marked this merge request as ready

  • Rahul Chanila changed the description

    changed the description

  • Rahul Chanila requested review from @tigerwnz

    requested review from @tigerwnz

  • Author Maintainer

    @obaiye can you please do the frontend review? Thanks!

  • Rahul Chanila requested review from @obaiye

    requested review from @obaiye

  • Rahul Chanila requested review from @gdoyle

    requested review from @gdoyle

  • mentioned in issue #500217 (closed)

  • Tiger Watson approved this merge request

    approved this merge request

  • Tiger Watson requested review from @proglottis

    requested review from @proglottis

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • :tools: Generated by gitlab_quality-test_tooling.


    :snail: Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

    Click to expand
    Job File Name Duration Expected duration
    #8524027304 spec/features/projects/container_registry_spec.rb#L140 Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 62.69 s < 50.13 s
    #8524027304 spec/features/projects/container_registry_spec.rb#L155 Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 52.25 s < 50.13 s
    #8524027361 spec/features/projects/container_registry_spec.rb#L140 Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 64.66 s < 50.13 s
    #8524027361 spec/features/projects/container_registry_spec.rb#L155 Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 53.96 s < 50.13 s
    #8525271991 spec/features/projects/container_registry_spec.rb#L140 Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 62.04 s < 50.13 s
    #8525271991 spec/features/projects/container_registry_spec.rb#L155 Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 51.55 s < 50.13 s
    #8525272045 spec/features/projects/container_registry_spec.rb#L140 Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 63.21 s < 50.13 s
    #8525272045 spec/features/projects/container_registry_spec.rb#L155 Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 52.53 s < 50.13 s
    #8551187939 spec/features/projects/container_registry_spec.rb#L140 Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 62.47 s < 50.13 s
    #8551187939 spec/features/projects/container_registry_spec.rb#L155 Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 51.56 s < 50.13 s
    #8551187984 spec/features/projects/container_registry_spec.rb#L140 Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 63.72 s < 50.13 s
    #8551187984 spec/features/projects/container_registry_spec.rb#L155 Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 53.01 s < 50.13 s
  • A deleted user added rspec:slow test detected label
  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 4cb5a2c8

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 86     | 0      | 4       | 0     | 90    | ✅     |
    | Monitor     | 16     | 0      | 0       | 0     | 16    | ✅     |
    | Create      | 258    | 0      | 44      | 0     | 302   | ✅     |
    | Plan        | 152    | 0      | 0       | 0     | 152   | ✅     |
    | Package     | 50     | 0      | 22      | 0     | 72    | ✅     |
    | Govern      | 150    | 0      | 6       | 0     | 156   | ✅     |
    | Data Stores | 66     | 0      | 2       | 0     | 68    | ✅     |
    | Fulfillment | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Release     | 10     | 0      | 0       | 0     | 10    | ✅     |
    | Analytics   | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Secure      | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Manage      | 2      | 0      | 2       | 0     | 4     | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 806    | 0      | 82      | 0     | 888   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for 4cb5a2c8

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 140    | 0      | 20      | 0     | 160   | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
    | Verify      | 49     | 0      | 16      | 0     | 65    | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Govern      | 84     | 0      | 9       | 1     | 93    | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Analytics   | 2      | 0      | 0       | 1     | 2     | ✅     |
    | Fulfillment | 2      | 0      | 7       | 1     | 9     | ✅     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 436    | 0      | 119     | 3     | 555   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Rahul Chanila added 1 commit

    added 1 commit

    • 1dd1d713 - Stub feature flag for ee spec

    Compare with previous version

  • Rahul Chanila reset approvals from @tigerwnz by pushing to the branch

    reset approvals from @tigerwnz by pushing to the branch

  • Rahul Chanila added 1 commit

    added 1 commit

    • 4cb5a2c8 - Fix computed property naming

    Compare with previous version

  • Rahul Chanila requested review from @tigerwnz

    requested review from @tigerwnz

  • Gina Doyle approved this merge request

    approved this merge request

  • James Fargher approved this merge request

    approved this merge request

    • Resolved by Tiger Watson

      Hi @rchanila The container registry component is not mounting at all for me. However the Vue tests are passing, which is surprising. Is there a step missing in the How To Test section?

      Screenshot_2024-12-03_at_11.08.38_AM

      When I run the tests in registry_settings_spec.rb I'm also getting a schema error, which is why I wonder if there's a step missing - unless there's something wrong in my local environment.

      Screenshot_2024-12-03_at_11.14.28_AM

  • Just some clarifying questions. showContainerRegistrySettings is injected as false for me.

    Edited by Oiza Baiye
  • Rahul Chanila changed the description

    changed the description

  • Rahul Chanila requested review from @obaiye

    requested review from @obaiye

  • Oiza Baiye approved this merge request

    approved this merge request

  • Oiza Baiye requested review from @ankit.panchal

    requested review from @ankit.panchal

  • Rahul Chanila requested review from @kushalpandya and removed review request for @ankit.panchal

    requested review from @kushalpandya and removed review request for @ankit.panchal

  • Kushal Pandya approved this merge request

    approved this merge request

  • Tiger Watson enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Hey there :wave:, could you please make sure this merge request gets merged?

    The merge request is set to auto-merge, but it is not currently mergeable (MR detailed_merge_status is discussions_not_resolved).

    This message was generated automatically. Improve it or delete it.

  • Rahul Chanila resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading