Skip GraphQL CSRF check when not session authed

Heinrich Lee Yurequested to merge
379326-fix-random-logouts into master

What does this MR do and why?

We only need to verify the CSRF token when the user is authenticated via a session cookie. This also makes it similar to other controllers where we raise an exception when the token does not match.

This fixes a race condition when restoring multiple tabs using the remember_me token where a CSRF mismatch can result to the user being logged out.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Heinrich Lee Yu

Merge request reports