"Remember me" checkbox at login does not behave as expected
Summary
When I log in to https://gitlab.com and I check the "Remember Me" checkbox, then I should stay logged in until I click "Log out" or I clear my cookies.
It should not matter how much time has elapsed since I logged in; even if I come back in a year's time, I should still be logged in.
If there is a time limit on how long I will be remembered, then the checkbox label should state what it is. However, it is much better UX for the checkbox to remember me until I explicitly log out, especially since gitlab.com now has a check before it will show the login box, with the phrase "you should be redirected in 5 seconds". I wasn't; after over a minute I eventually had to clear my cookies for gitlab.com and try again. And after that, I was not redirected to the page that I was on when I clicked "Log in", but instead on my default home page.
Steps to reproduce
- Log out of gitlab.com.
- Log in to gitlab.com, being sure to check the "remember me" checkbox.
- Close the tab and go away for a period of time (unfortunately, I don't know exactly how long this needs to be).
- Open a browser tab and enter gitlab.com in the address bar.
Example Project
n/a
What is the current bug behavior?
I am logged out, even though I did nothing to cause this.
What is the expected correct behavior?
I am still logged in, because I checked "remember me" and did not log out or clear my cookies.
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com
Results of GitLab environment info
n/a
Results of GitLab application Check
n/a
Possible fixes
Remove the timeout, or increase it to something much longer like 10 years.