Add audit event to BulkDeleteRunnersService
What does this MR do and why?
This MR adds an audit event when runners are deleted through the BulkDeleteRunner
GraphQL mutation (used in the Runners admin page).
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Go to http://gdk.test:3000/admin/runners
- Ensure you have some runners created
- Select a few runners and delete them from that page
- Check that the event was logged in http://gdk.test:3000/admin/audit_logs
Merge request reports
Activity
changed milestone to %17.7
assigned to @pedropombeiro
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels
- A deleted user
added documentation label
2 Warnings 7d75a803: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
2 Messages CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/user/compliance/audit_event_types.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer backend @syarynovskyi
(UTC+2, 1 hour ahead of author)
@grzesiek
(UTC+1, same timezone as author)
~"Verify" Reviewer review is optional for ~"Verify" @ayufan
(UTC+9, 8 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
- Resolved by Alejandro Rodríguez
requested review from @aish.sub
- A deleted user
added documentation label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-cng:
test report for 7d75a803expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 140 | 0 | 20 | 0 | 160 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Govern | 84 | 0 | 9 | 1 | 93 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Fulfillment | 2 | 0 | 7 | 1 | 9 | ✅ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 119 | 3 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-gdk:
test report for 7d75a803expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 25 | 0 | 11 | 0 | 36 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 403 | 0 | 41 | 0 | 444 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added 362 commits
-
7e66bf70...9eccd6b6 - 361 commits from branch
pedropombeiro/503315/0-fix-runner-audit-events
- 0f33b500 - Add audit event to BulkDeleteRunnersService
-
7e66bf70...9eccd6b6 - 361 commits from branch
requested review from @alejandro and removed review request for @aish.sub
added pipeline:mr-approved label
added 59 commits
-
0da45fac...626867e4 - 58 commits from branch
pedropombeiro/503315/0-fix-runner-audit-events
- e1323dcf - Add audit event to BulkDeleteRunnersService
-
0da45fac...626867e4 - 58 commits from branch
- Resolved by Alejandro Rodríguez
Thanks @alejandro! Could you please reapprove, since the upstream MR was merged and caused this one to lose your approval?
- Resolved by Max Fan
Hey @mfanGitLab
, mind doing the ~Verify review? The MR already has the backend approvals.
requested review from @mfanGitLab
started a merge train
mentioned in commit ed3d2e3d
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label